Add "-e" option to python cartridge to stop deploy process when it failed to install packages

openshift / origin-server

OpenShift 2 (deprecated)

889 stars 516 forks source link

Add "-e" option to python cartridge to stop deploy process when it failed to install packages #6357

Closed nak3 closed 8 years ago

nak3 commented 8 years ago

This PR fixes https://bugzilla.redhat.com/show_bug.cgi?id=1303796. However, this -e option has been removed by https://github.com/openshift/origin-server/pull/3542 purposely.

dinhxuanvu commented 8 years ago

[test]

Miciah commented 8 years ago

[test] [extended:cartridge]

nak3 commented 8 years ago

@dinhxuanvu @Miciah I can't open test results. But I don't think this change effects something. Could you please re-run test?

tiwillia commented 8 years ago

@nak3 looks like all the tests passed, but the acceptance script that is run at the end of testing failed:

E, [2016-02-02T11:49:15.809892 #4975] ERROR -- : 
SSH command ssh 2> /dev/null -t -n -o TCPKeepAlive=yes -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o PasswordAuthentication=no -i /var/lib/jenkins/.ssh/devenv.pem root@ec2-52-90-45-1.compute-1.amazonaws.com '/usr/bin/rhc-accept-devenv 2>&1' failed to ec2-52-90-45-1.compute-1.amazonaws.com with exit_code: 2  and output: FAIL: directory 56b0d788ff279cc97a00000a doesn't have a cartridge directory
FAIL: directory 56b0d788ff279cc97a00000a/.env doesn't have OPENSHIFT_PRIMARY_CARTRIDGE_DIR
2 ERRORS
Accept Node Output: , try 1 of 1
Devenv Acceptance Output = FAIL: directory 56b0d788ff279cc97a00000a doesn't have a cartridge directory
FAIL: directory 56b0d788ff279cc97a00000a/.env doesn't have OPENSHIFT_PRIMARY_CARTRIDGE_DIR

Lets re-[test] and see if this failure is spurious or not.

nak3 commented 8 years ago

Thank you @tiwillia! Hmm... test failed again and I can't see the result by Details button.

dinhxuanvu commented 8 years ago

@nak3 Are you working remotely? I'm a bit surprised that you are unable to access Jenkins. Also, the libra_ami is failed recently and it's been in process of rebuilding so please hold before doing another test/merge. Thanks.

dinhxuanvu commented 8 years ago

Ready for re-[test]

openshift-bot commented 8 years ago

Evaluated for online test up to aa3822b06dcaf2a4c7e57ac8e43bfd574fd55bc9

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9194/) (Extended Tests: cartridge)

tiwillia commented 8 years ago

@nak3 just a quick explanation - the latest test failures were unrelated. They were due to some spurious failures in the build of our openshift image we use for testing.

Jenkins should be available to you assuming you are on the proper vpn. Please contact me outside of github if you continue to have issues accessing jenkins.

dinhxuanvu commented 8 years ago

@nak3 Hi. So we have a plan in place for this issue. Since the "-e" was removed due to regression issue, we can't simply merge this PR yet. Instead, we will create an fork image with this specific change and run it pass QA regression suite. Then, based on the result of that run, we will decide what will happen next. I hope this makes sense. This may take a bit of time since QE team is in holiday this week. Thanks!

tiwillia commented 8 years ago

Regression testing complete. Commencing [merge] sequence.

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6711/) (Image: devenv_5772)

openshift-bot commented 8 years ago

Evaluated for online merge up to aa3822b06dcaf2a4c7e57ac8e43bfd574fd55bc9