search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Bug 1104750 - oo-admin-chk --level 0 takes too long in prod #6358

Closed dinhxuanvu closed 8 years ago

dinhxuanvu commented 8 years ago

The current threshold for gear creation time is 10 minutes (600 seconds) which ends up generating a lot of false errors during oo-admin-chk run as the command takes a long time to complete and during that time period gears can be deleted and created.

This commit increases the threshold to 6 hours (21600 seconds) to reduce the false errors generated oo-admin-chk.

Bug 1104750 Linkhttps://bugzilla.redhat.com/show_bug.cgi?id=1104750

Signed-off-by: Vu Dinh vdinh@redhat.com

dinhxuanvu commented 8 years ago

@a13m [test]. We increase the threshold to 6 hours and that would reduce the false positives on the error report from oo-admin-chk. Unless you have a different number in mind, would like to get your :+1: before merging. Thanks :)

openshift-bot commented 8 years ago

Evaluated for online test up to 8c7030c1b7dd550b1fe5db6a4db10e8a3fa4d041

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9178/)

dinhxuanvu commented 8 years ago

@tiwillia @Miciah Have checked with agrimm and confirmed the new time threshold is good. Please bless this PR with a merge tag please :)

tiwillia commented 8 years ago

Excellent, thanks for this @dinhxuanvu. Lets go ahead and [merge] since we have passing tests and the :+1: from @a13m

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6699/) (Image: devenv_5761)

openshift-bot commented 8 years ago

Evaluated for online merge up to 8c7030c1b7dd550b1fe5db6a4db10e8a3fa4d041