search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

fixup from PR 6342, add apache-vhost plugin ssl-crt-chain-path refs back #6359

Closed sallyom closed 8 years ago

sallyom commented 8 years ago

(was removed with PR #6342)

sallyom commented 8 years ago

@Miciah please review

tiwillia commented 8 years ago

[test]

sallyom commented 8 years ago

@Miciah, I don't think we need https://github.com/openshift/origin-server/commit/62ef0ec522b0fe26050d7c375ee5098c060b1d5c#diff-b0577d090311ee97b05ba0b6d4e55858L388 ? I believe this is now the same as 'ssl_certificate_file = ssl_certificate_path(server_alias)' here. 'I believe' != 'I am 100% positive'

openshift-bot commented 8 years ago

Evaluated for online test up to cccf66cdee8e2fcbc360d56f8df3e4e244c6a239

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9183/)

sallyom commented 8 years ago

@Miciah, good?

Miciah commented 8 years ago

Spiffin'!

Miciah commented 8 years ago

Please [merge]!

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6700/) (Image: devenv_5762)

openshift-bot commented 8 years ago

Evaluated for online merge up to cccf66cdee8e2fcbc360d56f8df3e4e244c6a239