search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

oo-accept-node: check-quotas: fix mnt opts parsing #6370

Closed Miciah closed 8 years ago

Miciah commented 8 years ago

Improve the parsing of mount options from the mount command's output by properly splitting on newlines and then removing the parentheses around the mount options.

Before this commit, the pattern match /loop=([^,]+)/ on the mount options was capturing the right parenthesis and newline from the mount command's output if the loop option was the last mount option.

This commit is related to bug 1265811.

https://bugzilla.redhat.com/show_bug.cgi?id=1265811

Miciah commented 8 years ago

Please [test]!

openshift-bot commented 8 years ago

Evaluated for online test up to 896aba36d358cda1bd7b1a5d229704d995c72d4d

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9221/)

tiwillia commented 8 years ago

LGTM!

[merge]

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6717/) (Image: devenv_5778)

openshift-bot commented 8 years ago

Evaluated for online merge up to 896aba36d358cda1bd7b1a5d229704d995c72d4d

Miciah commented 8 years ago

Yay! Thanks!