search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

cron_runjobs.sh: Feature Enhancement for syslog tagging #6381

Closed sferich888 closed 8 years ago

sferich888 commented 8 years ago

Bug 1217403 Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1217403

Adding the ability to filter/tag cron messages with syslog

sferich888 commented 8 years ago

The rsyslog configuration file also needs to be modified for this to work. 

:syslogtag, isequal, "cron_sys_log:" /var/log/ABC.log

This needs to be added to the config, to specify where you wan to send the cron logs. Documentation on this should be updated with https://bugzilla.redhat.com/show_bug.cgi?id=1328495

sferich888 commented 8 years ago

[test]

Miciah commented 8 years ago

@sferich888, thanks! Looks good. Do we want to configure rsyslog to log system-level cron logging output to a separate file as you describe (maybe /var/log/openshift/node/cron.log) by default? If so, I will make the PR for the installation script.

sferich888 commented 8 years ago

@Michiah your call I honestly think letting an admin pick the location is a feature but I see the benefit of defining a default at install time.

Miciah commented 8 years ago

Yeah, the administrator can always modify /etc/rsyslog.d/imuxsock-and-openshift-gears.conf after installation to comment out the line or change the path (which will be easier to do if the :syslogtag stanza is already there).

Miciah commented 8 years ago

The tests got a lot of timeouts—most likely we got a dud EC2 instance. Please [test] again!

openshift-bot commented 8 years ago

Evaluated for online test up to 96ab0c03099d35a23f31089a22f60fab31957559

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9270/)

Miciah commented 8 years ago

Lovely jubbly! openshift-bot, please [merge]!

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6726/) (Image: devenv_5785)

openshift-bot commented 8 years ago

Evaluated for online merge up to 96ab0c03099d35a23f31089a22f60fab31957559