search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Tomcat does not properly parse spaces in JVM parameters #6383

Closed dinhxuanvu closed 8 years ago

dinhxuanvu commented 8 years ago

Tomcat script doesn't correct handle the white places in the parameters passing via env variable JAVA_OPTS_EXT which causes the JVM fails to parse the parameters correctly during execution.

The tomcat bash script is modified to handle the white spaces and ensured the space is not ignored by adding the extra double quotes around the "JAVA_OPTS_EXT".

Bug: 1282852 Link: https://bugzilla.redhat.com/show_bug.cgi?id=1282852

Signed-off-by: Vu Dinh vdinh@redhat.com

dinhxuanvu commented 8 years ago

[test]

dinhxuanvu commented 8 years ago

@Miciah Please review. Thanks :)

dinhxuanvu commented 8 years ago

@Miciah Fixed and tested :D... Please review again and bless it with a merge tag if you wish :D...

Miciah commented 8 years ago

openshift-bot, please [test]! [extended:cartridge]

dinhxuanvu commented 8 years ago

re-[test]

Miciah commented 8 years ago

Please [test] again!

openshift-bot commented 8 years ago

Evaluated for online test up to 7a0be7537cc5ce7b2749bca5a19a64f62cb97f6c

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9303/) (Extended Tests: cartridge)

dinhxuanvu commented 8 years ago

Everything looks good. Until you have something to add @Miciah, please bless it with a merge :)

Miciah commented 8 years ago

openshift-bot, please [merge]!

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6730/) (Image: devenv_5791)

openshift-bot commented 8 years ago

Evaluated for online merge up to 7a0be7537cc5ce7b2749bca5a19a64f62cb97f6c