openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

fix extended tests RestClient.delete #6385

Closed sallyom closed 8 years ago

sallyom commented 8 years ago

@Miciah @tiwillia woot woot! [test][extended:cartridge,gear]

tiwillia commented 8 years ago

Ah, nice job! This LGTM.

Do we want to also do the extended node test or is there a reason it was excluded?

sallyom commented 8 years ago

[test] [extended:node,broker,rhc,cartridge,gear] pleeeeese!

sallyom commented 8 years ago

[test] [extended:node,broker,rhc,cartridge,gear] pleeeeese!

thrasher-redhat commented 8 years ago

Lots of weird tests in that last attempt. Look like most of them timed out for some reason. May want to test again.

sallyom commented 8 years ago

[test] [extended:node,broker,rhc,cartridge,gear] pleeeeese!

sallyom commented 8 years ago

[test] [extended:node,broker,rhc,cartridge,gear] pleeeeese (I'm impatient)!

sallyom commented 8 years ago

@tiwillia just the site extended tests are failing...I didn't mean to run the extended:site, bc of the known failures. Should be all set other than that.

dinhxuanvu commented 8 years ago

[test] [extended:node,broker,rhc,cartridge,gear]

dinhxuanvu commented 8 years ago

[test] [extended:node,broker,rhc,cartridge,gear] please!

sallyom commented 8 years ago

[test] [extended:node,broker,rhc,cartridge,gear] please!

openshift-bot commented 8 years ago

Evaluated for online test up to 8b3e74d255b0af8d3742fcd18963322bdf8421e3

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9302/) (Extended Tests: node, broker, rhc, cartridge, gear)

dinhxuanvu commented 8 years ago

Finally, it has passed. @Miciah Any final thoughts? A merge blessing :100:

Miciah commented 8 years ago

Lovely jubbly! openshift-bot, please [merge]!

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6729/) (Image: devenv_5790)

openshift-bot commented 8 years ago

Evaluated for online merge up to 8b3e74d255b0af8d3742fcd18963322bdf8421e3

Miciah commented 8 years ago

Thanks!