search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Update resource_limits.conf #6399

Closed thrasher-redhat closed 8 years ago

thrasher-redhat commented 8 years ago

Bug 1196783 https://bugzilla.redhat.com/show_bug.cgi?id=1196783

When the memory_limit_in_bytes variable in resource_limits.conf is updated, the OPENSHIFT_GEAR_MEMORY_MB env variable does not get updated for existing gears. Now there is an additional note for users to run a workaround to update that variable for existing gears.

thrasher-redhat commented 8 years ago

@tiwillia

For review at your leisure. Debating whether I should put a comment directly on the memory_limit_in_bytes line.

dinhxuanvu commented 8 years ago

LGTM. Just a simple doc change. @abhgupta Would you mind reviewing/merging this since Tim and Miciah are both in PTO.

abhgupta commented 8 years ago

@thrasher-redhat I agree that placing the comment right above the memory_limit_in_bytes line would make more sense.

Otherwise, LGTM

thrasher-redhat commented 8 years ago

@abhgupta Updated the comment to appear both at the top (along with the other instructions for what to do when updating the file) and just above the variable itself.

abhgupta commented 8 years ago

[merge] lgtm

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9331/) (Image: devenv_5803)

Miciah commented 8 years ago

Dependency problems again:

Gem::InstallError: json requires Ruby version ~> 2.0.
An error occurred while installing json (2.0.1), and Bundler cannot continue.
Make sure that `gem install json -v '2.0.1'` succeeds before bundling.
abhgupta commented 8 years ago

re-[merge] the merge failure was due to a gem dependency issue and was resolved in a separate PR

openshift-bot commented 8 years ago

Evaluated for online merge up to 505b7922fe1d5f8a69e2537e535bdb035d2e3933