search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Allow maximum allowed user defined env variables to be configured #6403

Closed tiwillia closed 8 years ago

tiwillia commented 8 years ago

Bug 1266239 https://bugzilla.redhat.com/show_bug.cgi?id=1266239

Adds the USER_VARIABLE_MAX_COUNT option to the node configuration file. This option controls the maximum number of user environment variables allowed on the node.

tiwillia commented 8 years ago

[test]

@thrasher-redhat can you review please?

thrasher-redhat commented 8 years ago

LGTM

tiwillia commented 8 years ago

re-[test] please.

tiwillia commented 8 years ago

@thrasher-redhat can you give this one more quick look? Made a small change so that the default '50' would work.

thrasher-redhat commented 8 years ago

LGTM. Default 50 sounds solid.

Miciah commented 8 years ago

openshift-bot, please [merge]!

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9341/) (Image: devenv_5806)

tiwillia commented 8 years ago

Using config.get('VALUE', default), tests seem to be unable to determine the default value. I can confirm that in actual use, the default is properly established when 'VALUE' does not exist. However the default is not established in tests.

@Miciah, I've modified the line to match what other application_container_ext modules are doing, like so:

user_variable_max_count = (config.get('USER_VARIABLE_MAX_COUNT') || "50" ).to_i

This works in tests and in the real world.

tiwillia commented 8 years ago

re-[test] please

openshift-bot commented 8 years ago

Evaluated for online merge up to a4bee2ecfe84a166dac4a9f922dff99f973bb0f3

openshift-bot commented 8 years ago

Evaluated for online test up to a4bee2ecfe84a166dac4a9f922dff99f973bb0f3

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9342/)