search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

routing-daemon: F5: Rescue more network errors #6407

Closed Miciah closed 8 years ago

Miciah commented 8 years ago

F5IControlRestLoadBalancerModel#rest_request: Rescue several additional exceptions that failure to connect to the F5 BIG-IP host can raise, and attempt retries for these exceptions.

Newer versions of the restclient gem should wrap these exceptions, but there has been at least one report where restclient let through an unwrapped exception (Errno::ETIMEDOUT), and as a result, F5IControlRestLoadBalancerModel#rest_request did not rescue the exception and thus did not follow the retry logic.

This commit is related to commit f9d47828016d5085bdd9da252300c6feb642e9d6.

This commit is related to bug 1227472.

https://bugzilla.redhat.com/show_bug.cgi?id=1227472

tiwillia commented 8 years ago

I don't see any issues with this approach. LGTM

tiwillia commented 8 years ago

We don't have any tests that test the routing daemon at all, right?

Miciah commented 8 years ago

Thanks! That's right. :cry:

tiwillia commented 8 years ago

Well then lets go ahead and [merge]

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9345/) (Image: devenv_5807)

openshift-bot commented 8 years ago

Evaluated for online merge up to dc1be12088a1da3e59a1d3f6de656adfef339ca7