search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Use updated fakefs to ensure support for File.absolute_path #6411

Closed tiwillia closed 8 years ago

tiwillia commented 8 years ago

The use of fakes-0.4.2 causes erroneous test failures due to the lack of File.absolute_path support. Updating to 0.5.* allows tests to succeed without causing further issues.

In origin-server tests, fakefs-0.9 is used by default. This change will have no affect on origin-server tests, but will ensure that tests run in other deployments will be run properly.

@thrasher-redhat fyi

tiwillia commented 8 years ago

[test] just for fun's sake.

openshift-bot commented 8 years ago

Evaluated for online test up to 047580625b397c0915b0d344a266be392f24915c

tiwillia commented 8 years ago

@Miciah, can you review/merge this when you get a chance?

Miciah commented 8 years ago

So in discussions on IRC, we thought the version of fakefs was too new, but it turns out it was too old; is that right?

tiwillia commented 8 years ago

@Miciah that is correct. fakefs was too old and did not support some methods that have been implemented in File.

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9360/)

tiwillia commented 8 years ago

Hold off on this please, don't merge yet.

tiwillia commented 8 years ago

This isn't necessary, a newer version will always be used. Closing.