search

openshift / origin-server

OpenShift 2 (deprecated)
888 stars 516 forks source link

Perform quota operations on gear, not application #6416

Closed tiwillia closed 8 years ago

tiwillia commented 8 years ago

The get_quota and set_quota methods take a gear argument. An application object will work as the argument due to supporting similar methods, such as the UUID method. However, an application's uuid will differ from a gear's uuid when predictable uuid's are used.

Bug 1365390 https://bugzilla.redhat.com/show_bug.cgi?id=1365390

tiwillia commented 8 years ago

[test]

@vdinh PTAL

@sallyom FYI

tiwillia commented 8 years ago

update_cluster should always be run from the first web_proxy gear as far as the controller is concerned. The first web_proxy gear should always be the head gear of the application. There shouldn't be any reason to use the gear's application to ensure the head gear is used.

openshift-bot commented 8 years ago

Evaluated for online test up to 71568b88911815c4ed2264a909c6aa14a6caa8a5

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9380/)

dinhxuanvu commented 8 years ago

LGTM

tiwillia commented 8 years ago

[merge]

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9381/) (Image: devenv_5819)

openshift-bot commented 8 years ago

Evaluated for online merge up to 71568b88911815c4ed2264a909c6aa14a6caa8a5