openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Revert dfac396 and enable routing notifications during moves #6417

Closed tiwillia closed 8 years ago

tiwillia commented 8 years ago

The routing daemon was previously not receiving updated endpoint notifications during gear moves. A previous commit, dfac396, enabled endpoints to be published but the endpoints published were the same endpoints as before the move.

This change reverts dfac396 and properly sends endpoint creation and deletion events to the routing daemon during a gear move.

tiwillia commented 8 years ago

@Miciah @sallyom PTAL

[test]

Miciah commented 8 years ago

Looks super!

tiwillia commented 8 years ago

With a review and a successful test, lets [merge] please!

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9383/) (Image: devenv_5820)

openshift-bot commented 8 years ago

Evaluated for online merge up to 1c28f14a1084339e2d9ae1f73ae9db286f005571

openshift-bot commented 8 years ago

Evaluated for online test up to 1c28f14a1084339e2d9ae1f73ae9db286f005571

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9384/)

Miciah commented 8 years ago

Yay!