search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Consistent session cookies across haproxies in HA apps #6421

Closed codificat closed 7 years ago

codificat commented 8 years ago

Make the local-gear set a cookie value using the gear's DNS name, the same that remote gears do, so that HA applications get consistent session cookie values across multiple haproxies.

See https://bugzilla.redhat.com/1377433

thrasher-redhat commented 8 years ago

LGTM

Miciah commented 8 years ago

[test][extended:cartridge,gear]

Miciah commented 8 years ago

AWS::EC2::Errors::InternalError while provisioning. Please [test] again.

openshift-bot commented 8 years ago

Evaluated for online test up to 8b2e63ad40da935b4cda3cca96fda06af6d90bd4

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9404/) (Extended Tests: cartridge, gear)

thrasher-redhat commented 7 years ago

@Miciah - was there anything else needed for this PR or are we good to merge?

Miciah commented 7 years ago

@thrasher-redhat, good to merge.

openshift-bot, please [merge]!

Miciah commented 7 years ago

openshift-bot, please really [merge]!

Miciah commented 7 years ago

Hoping this is a fluke:

# cucumber --strict -f progress -f rerun --out /tmp/rerun_ae323edba1d85775675592845950d773.txt  -f junit --out /tmp/rhc/cucumber_results -t @node3 -t ~@not-rhel -t ~@not-origin -r openshift-test/tests @/tmp/rerun_e6125d5278aed18ac2acd2c702da3d6a.txt

Using RSpec 2
simple: 30784 ruby 1.9.3 2013-11-22 [x86_64-linux]
F-----

(::) failed steps (::)

Could not create application 1 (RuntimeError)
./openshift-test/controller/test/cucumber/step_definitions/application_steps.rb:54:in `/^a new client created( scalable)? (.+) application$/'
openshift-test/tests/platform-endpoints.feature:6:in `Given a new client created scalable mock-0.3 application'

Failing Scenarios:
cucumber openshift-test/tests/platform-endpoints.feature:5 # Scenario: SSL to Gear is specified in the cartridge's manifest.yml

openshift-bot, please try one more time to [merge]!

openshift-bot commented 7 years ago

Evaluated for online merge up to 8b2e63ad40da935b4cda3cca96fda06af6d90bd4

openshift-bot commented 7 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9439/) (Base Commit: 5e9395b5661cb957e118b5dd9ffe632a102d19b2) (Image: devenv_5830)

Miciah commented 7 years ago

Yay! Thanks!