search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

Allow start_priority to determine whether a gear should be idled #6422

Closed a13m closed 8 years ago

a13m commented 8 years ago

The gears which we set a special start priority on are also gears which we do not want to idle. This change allows the idler to skip gears based on start priority, regardless of whether they have been recently accessed.

tiwillia commented 8 years ago

[test] please.

tiwillia commented 8 years ago

Failure appears to be unrelated:

          -----------------------------------------------------------
                      Begin Output From Site Check Javascripts Tests
          -----------------------------------------------------------

# cd openshift-test/site; bundle exec rake test:check:js

/opt/rh/ruby193/root/usr/bin/rake: No such file or directory - phantomjs --version
rake aborted!
PhantomJS returned non-zero exit status 127. Make sure phantomjs runs successfully on your system. You can test this by just running the `phantomjs` command which should give you a Javascript REPL.

Tasks: TOP => konacha:run
(See full trace by running task with --trace)

          -----------------------------------------------------------
                       End Output From Site Check Javascripts Tests
          -----------------------------------------------------------
tiwillia commented 8 years ago

Looks like a flake to me:

# phantomjs --version
1.9.0
# echo $?
0

The first time I ran phantomjs --version it took almost 2 minutes to return. Returns almost immediately afterwards.

[test] again please.

tiwillia commented 8 years ago

Test failure should be resolved, please re-[test]

openshift-bot commented 8 years ago

Evaluated for online test up to 7cedf41b2d307761f1d42783dd8e587bc359bc4d

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9390/)

tiwillia commented 8 years ago

[merge] please!

openshift-bot commented 8 years ago

Evaluated for online merge up to 7cedf41b2d307761f1d42783dd8e587bc359bc4d

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9392/) (Image: devenv_5824)