search

openshift / origin-server

OpenShift 2 (deprecated)
888 stars 516 forks source link

[TO_STAGE] Various quota-related fixes #6428

Closed a13m closed 8 years ago

a13m commented 8 years ago

This is a collection of cherry-picked changes related to the resolution of these two bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1292133 https://bugzilla.redhat.com/show_bug.cgi?id=1122084

Ideally it should be reviewed by @sallyom @Miciah and @tiwillia to check whether other commits are necessary.

tiwillia commented 8 years ago

It looks like you caught everything here. I'd rather test it before merging though. Will get something running today.

[test], even though the automated tests likely won't cover everything we need them to.

sallyom commented 8 years ago

@a13m I believe all the changes related to those 2 bzs are included in this PR. @tiwillia please test today before merging, and thanks (for setting up/testing instead of me doing it) :)

tiwillia commented 8 years ago

I can verify that starts and stops of at-quota gears works up until the 120% limit.

I can verify that the nodes are exposing the new node_disk_free and node_total_size facts through mcollective.

I can also verify that moving a gear using 100% quota is successful due to the use of the new quota buffer.

This LGTM

tiwillia commented 8 years ago

[test] again to ensure that isn't a flake

thrasher-redhat commented 8 years ago

We should have ultron in stage now, re[test] please!

thrasher-redhat commented 8 years ago

This error (addressible gem has a new version and dependency on public_suffix) is something that we just saw in master. It involved a small change to the the Gemfile as seen here: https://github.com/openshift/rhc/commit/a271add215ff288fd709848375ac514ee85ac200

We'll likely need to pull that commit into rhc's stage.

wshearn commented 8 years ago

[test]

openshift-bot commented 8 years ago

Evaluated for online test up to 4258d00182ad1397a444a1bd747b6f1d27aa5d1d

openshift-bot commented 8 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests_generic/761/) (Base Commit: 29bdc45d129da74a04dc4ac996e459c63435eefc)

wshearn commented 8 years ago

[merge]

openshift-bot commented 8 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests_generic/761/) (Base Commit: 29bdc45d129da74a04dc4ac996e459c63435eefc) (Image: devenv-stage_1227)

openshift-bot commented 8 years ago

Evaluated for online merge up to 4258d00182ad1397a444a1bd747b6f1d27aa5d1d