search

openshift / origin-server

OpenShift 2 (deprecated)
888 stars 516 forks source link

routing-daemon: Let listen rescue exceptions #6436

Closed Miciah closed 7 years ago

Miciah commented 7 years ago

RoutingDaemon#handle: Remove exception handling in order to let exceptions bubble up to RoutingDaemon#listen.

RoutingDaemon#listen: Add a generic exception handler to make sure that any exceptions that had been handled by RoutingDaemon#handle and would not otherwise be handled now by RoutingDaemon#listen get rescued and logged.

This commit is related to bug 1227472.

https://bugzilla.redhat.com/show_bug.cgi?id=1227472

thrasher-redhat commented 7 years ago

Letsssss [test]!

openshift-bot commented 7 years ago

Evaluated for online test up to b7bb810b7bd7502011a86fce14459b961bd53716

openshift-bot commented 7 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9442/) (Base Commit: e59d44a0e70be4cb315365bb6e1c2d31028e2733)

thrasher-redhat commented 7 years ago

LGTM. Not sure if you need/want anyone else to review.

tiwillia commented 7 years ago

LGTM :pizza:

Miciah commented 7 years ago

openshift-bot, please [merge]!

openshift-bot commented 7 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9442/) (Base Commit: e59d44a0e70be4cb315365bb6e1c2d31028e2733) (Image: devenv_5832)

openshift-bot commented 7 years ago

Evaluated for online merge up to b7bb810b7bd7502011a86fce14459b961bd53716