search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

routing-daemon: F5: Check if virtual servers exist #6440

Closed Miciah closed 7 years ago

Miciah commented 7 years ago

F5IControlRestLoadBalancerModel#initialize: Check whether the virtual servers specified in the routing-daemon's configuration exist in F5 BIG-IP, and provide a clear error message if either does not.

Also, add more logging.

thrasher-redhat commented 7 years ago

LGTM

tiwillia commented 7 years ago

LGTM :beers:

Miciah commented 7 years ago

Yay! Thanks! openshift-bot, please [merge]!

openshift-bot commented 7 years ago

[Test]ing while waiting on the merge queue

openshift-bot commented 7 years ago

Evaluated for online test up to 53a02ecc6ab3c6ddffd6988613625f7542539ce5

openshift-bot commented 7 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9446/) (Base Commit: 2fbcf346a1cbec8f24ecdff0047ea142539bf075)

Miciah commented 7 years ago

Looks like a flake:

    Scenario: SSL to Gear is specified in the cartridge's manifest.yml

Given a new client created scalable mock-0.3 application
Then the haproxy.cfg file will be configured to proxy SSL to the backend gear
When I send an http request to the app
Then It will return location https://testssl-testuser.dev.rhcloud.com
When I send an https request to the app
Then It will return content <html>\n  <body>\n    Goodbye, cruel world!\n  </body>\n</html>\n\n

Please [merge] again!

openshift-bot commented 7 years ago

Evaluated for online merge up to 53a02ecc6ab3c6ddffd6988613625f7542539ce5

openshift-bot commented 7 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9452/) (Base Commit: 923ad118c4ebf738f4a6600e31393254a71acaaf) (Image: devenv_5835)