search

openshift / origin-server

OpenShift 2 (deprecated)
889 stars 516 forks source link

routing-daemon: Improve logging of exceptions #6441

Closed Miciah closed 7 years ago

Miciah commented 7 years ago

RoutingDaemon#listen: When logging an exception, mention its class. Also, when NACKing a message from ActiveMQ because an exception was raised while handling it, log the exception. Finally, log ACKs (at debug level) in addition to NACKs (at info level).

thrasher-redhat commented 7 years ago

LGTM

tiwillia commented 7 years ago

LGTM :dancing_men:

Miciah commented 7 years ago

Thank you both! openshift-bot, please [merge]!

openshift-bot commented 7 years ago

Evaluated for online merge up to b5bfa1cdead16029f1e2798b093f8cdc4909fed1

openshift-bot commented 7 years ago

[Test]ing while waiting on the merge queue

openshift-bot commented 7 years ago

Evaluated for online test up to b5bfa1cdead16029f1e2798b093f8cdc4909fed1

openshift-bot commented 7 years ago

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9447/) (Base Commit: 2fbcf346a1cbec8f24ecdff0047ea142539bf075)

openshift-bot commented 7 years ago

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9451/) (Base Commit: d3d9f06d78e5e19425f938cc7481beab9e6f135c) (Image: devenv_5835)