search

openshift / origin-web-catalog

Apache License 2.0
18 stars 60 forks source link

Bump angular-ui-router dependency version to fix node engine compatibility issue #654

Closed TheRealJon closed 6 years ago

TheRealJon commented 6 years ago

Currently, the angular-ui-router package version is set to 1.0.0-beta.1. This version has a bug which causes the package to fail the node engine compatibility test: https://github.com/angular-ui/ui-router/issues/3086

When installing origin-web-catalog with Yarn, this causes a failure unless you use the --ignore-engines flag.

spadgett commented 6 years ago

@dtaylor113 Do you know why this isn't only a dev dependency? I think it's only used for the sample app?

spadgett commented 6 years ago

cc @jeff-phillips-18

jeff-phillips-18 commented 6 years ago

Not sure why it was made a dependency (probably my mistake early on), it definitely should only be a devDependency.

spadgett commented 6 years ago

/assign @TheRealJon

@TheRealJon can change it to a dev dependency?

spadgett commented 6 years ago

This has since been fixed by #655

/close