search

openshift / origin-web-console

Web Console for the OpenShift Application Platform
https://www.openshift.org/
Apache License 2.0
123 stars 230 forks source link

Bug 1782695: Supply the navigateResourceURL filter with kind and name space in the ConfigMap list page [enterprise-3.11] #3161

Closed jhadvig closed 4 years ago

jhadvig commented 4 years ago

Since we started to retrieving the PartialObjectMetadateList for ConfigMap list page in https://github.com/openshift/origin-web-console/pull/3152 we need to tell to the navigateResourceURL filter explicitly that we need URL for configmap resource, since the resourceURL service function is aware about first-class resource, not the PartialObjectMetadate that is used. Due to the fact that are are supplying the filter with PartialObjectMetadata object, null return value is returned from the navigateResourceURL filter.

/assign @spadgett

openshift-ci-robot commented 4 years ago

@jhadvig: This pull request references Bugzilla bug 1782695, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3161): >Bug 1782695: Supply the navigateResourceURL filter with kind and name space in the ConfigMap list page Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jhadvig commented 4 years ago

/retest

jhadvig commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@jhadvig: This pull request references Bugzilla bug 1782695, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3161#issuecomment-566806475): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jhadvig commented 4 years ago

/retest

benjaminapetersen commented 4 years ago

/bugzilla refresh

We won't have bugs in more recent releases.

openshift-ci-robot commented 4 years ago

@benjaminapetersen: This pull request references Bugzilla bug 1782695, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3161#issuecomment-567093875): >/bugzilla refresh > >We won't have bugs in more recent releases. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 4 years ago

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci-robot commented 4 years ago

@openshift-bot: This pull request references Bugzilla bug 1782695, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3161#issuecomment-570007167): >/bugzilla refresh > >The requirements for Bugzilla bugs have changed, recalculating validity. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jhadvig commented 4 years ago

/retest

jhadvig commented 4 years ago

/retest

openshift-ci-robot commented 4 years ago

@jhadvig: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins c28b2bd8ca064af2490be34f4ba2b99a3d2bd99c link /test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
spadgett commented 4 years ago

This bug only applies to 3.11.z since the 4.x console has a different code base. It was also introduced by #3152, which is only in 3.11.z. Manually adding the valid-bug label.

Additionally the Jenkins tests are broken due to the Chrome version in use. I've manually verified the change.

/override ci/openshift-jenkins

openshift-ci-robot commented 4 years ago

@spadgett: Overrode contexts on behalf of spadgett: ci/openshift-jenkins

In response to [this](https://github.com/openshift/origin-web-console/pull/3161#issuecomment-571748205): >This bug only applies to 3.11.z since the 4.x console has a different code base. It was also introduced by #3152, which is only in 3.11.z. Manually adding the valid-bug label. > >Additionally the Jenkins tests are broken due to the Chrome version in use. I've manually verified the change. > >/override ci/openshift-jenkins Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@jhadvig: All pull requests linked via external trackers have merged. Bugzilla bug 1782695 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin-web-console/pull/3161): >Bug 1782695: Supply the navigateResourceURL filter with kind and name space in the ConfigMap list page [enterprise-3.11] Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.