search

openshift / origin-web-console

Web Console for the OpenShift Application Platform
https://www.openshift.org/
Apache License 2.0
123 stars 230 forks source link

Bug 1760767: fix bug where container image name does not display cor… #3166

Closed rhamilto closed 4 years ago

rhamilto commented 4 years ago

…rectly

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1760767

Discussed this with @spadgett and determined the safest and best fix is to simply display the image name as is and don't try to do clever display of the data.

Screen Shot 2020-02-06 at 2 39 49 PM

openshift-ci-robot commented 4 years ago

@rhamilto: This pull request references Bugzilla bug 1760767, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3166): >Bug 1760767: fix bug where container image name does not display cor… Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rhamilto commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@rhamilto: This pull request references Bugzilla bug 1760767, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3166#issuecomment-583088800): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rhamilto commented 4 years ago

@benjaminapetersen, not sure how to get around the bugzilla dependency requirement given this bug doesn't exist in 4.x.

openshift-ci-robot commented 4 years ago

@rhamilto: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins 1762f7a1925ee5e626f6cfcf3852d0f617365bd2 link /test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
spadgett commented 4 years ago

/override ci/openshift-jenkins

Manually adding the valid bug label. The 4.x console is a different code base that doesn't have this bug.

openshift-ci-robot commented 4 years ago

@spadgett: Overrode contexts on behalf of spadgett: ci/openshift-jenkins

In response to [this](https://github.com/openshift/origin-web-console/pull/3166#issuecomment-583201864): >/override ci/openshift-jenkins > >Manually adding the valid bug label. The 4.x console is a different code base that doesn't have this bug. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@rhamilto: All pull requests linked via external trackers have merged. Bugzilla bug 1760767 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin-web-console/pull/3166): >Bug 1760767: fix bug where container image name does not display cor… Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.