search

openshift / origin-web-console

Web Console for the OpenShift Application Platform
https://www.openshift.org/
Apache License 2.0
123 stars 230 forks source link

Bug 1828635: Bump jQuery to v3.5.1 and fix templating bug #3171

Closed rhamilto closed 4 years ago

rhamilto commented 4 years ago

jQuery v3.5.0 contains a breaking change to Bootstrap; v3.5.1 contains the fix for said bug. Additionally, there was a template bug that updating to jQuery 3.5.x unmasked, but is now fixed.

Follow on fix to #3170

openshift-ci-robot commented 4 years ago

@rhamilto: This pull request references Bugzilla bug 1828635, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3171): >Bug 1828635: Bump jQuery to v3.5.1 and fix templating bug Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@rhamilto: This pull request references Bugzilla bug 1828635, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3171): >Bug 1828635: Bump jQuery to v3.5.1 and fix templating bug Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@rhamilto: This pull request references Bugzilla bug 1828635, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/origin-web-console/pull/3171): >Bug 1828635: Bump jQuery to v3.5.1 and fix templating bug Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
spadgett commented 4 years ago

/override ci/openshift-jenkins

openshift-ci-robot commented 4 years ago

@spadgett: Overrode contexts on behalf of spadgett: ci/openshift-jenkins

In response to [this](https://github.com/openshift/origin-web-console/pull/3171#issuecomment-630402991): >/override ci/openshift-jenkins Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
spadgett commented 4 years ago

Manually adding the valid bug label since 3.11.z bugs don't require a dependent bug.

openshift-ci-robot commented 4 years ago

@rhamilto: Bugzilla bug 1828635 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin-web-console/pull/3171): >Bug 1828635: Bump jQuery to v3.5.1 and fix templating bug Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.