search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.5k stars 4.7k forks source link

oc set image should return a reasonable error when used with build configs #10947

Closed 0xmichalis closed 8 years ago

0xmichalis commented 8 years ago

Right now it doesn't output anything if you pass an arbitrary container name and image name.

cc: @mfojtik

bparees commented 8 years ago

presumably this issue is blocked by https://github.com/openshift/origin/issues/10945

mfojtik commented 8 years ago

@bparees it will be a follow up :-)

bparees commented 8 years ago

@kargakis after discussing with @mfojtik this sounds like an upstream issue that set image needs to report an error for any resource that doesn't contain a pod spec, it's not a build specific thing. agree?

0xmichalis commented 8 years ago

sure, Michal mentioned buildconfigs I guess because that's the only non-podspec-y thing I would try to set an image to, hence I assigned it to you but feel free to pass it back to PM

On Fri, Sep 16, 2016 at 12:57 PM, Ben Parees notifications@github.com wrote:

@kargakis https://github.com/kargakis after discussing with @mfojtik https://github.com/mfojtik this sounds like an upstream issue that set image needs to report an error for any resource that doesn't contain a pod spec, it's not a build specific thing. agree?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openshift/origin/issues/10947#issuecomment-247573350, or mute the thread https://github.com/notifications/unsubscribe-auth/ADuFfxiMefhqHhxsu1NGmk2dmBf8PO6Tks5qqnYjgaJpZM4J-vbi .

bparees commented 8 years ago

@PI-Victor i heard a rumor you were interested in an upstream issue. do you want to take this? (needs to be opened against k8s and then addressed)

PI-Victor commented 8 years ago

@bparees yes, if it's not extremely urgent, i'd like to give it a shot.

bparees commented 8 years ago

@PI-Victor i don't think it's urgent. please open an upstream issue and close this one.

PI-Victor commented 8 years ago

so begins my first issue with k8s: https://github.com/kubernetes/kubernetes/issues/32865 as @bparees suggested, closing this.