cluster up extended tests do not run on mac

spadgett commented 6 years ago

TSB provision.sh script appears to call base64 with an option that doesn't work on macOS.

FAILURE after 76.000s: test/extended/clusterup.sh:186: executing 'pushd /Users/sam/go/src/github.com/openshift/origin/pkg/templateservicebroker/servicebroker/test-scripts; serviceUUID=f2c9d630-daad-11e7-9364-fec80fd78fe2 ./provision.sh' expecting success: the command returned the wrong error code
Standard output from the command:
/Users/sam/go/src/github.com/openshift/origin/pkg/templateservicebroker/servicebroker/test-scripts ~ /Users/sam/go/src/github.com/openshift/origin

Standard error from the command:
base64: invalid option -- w
Usage:  base64 [-hvD] [-b num] [-i in_file] [-o out_file]
  -h, --help     display this message
  -D, --decode   decodes input
  -b, --break    break encoded string into num character lines
  -i, --input    input file (default: "-" for stdin)
  -o, --output   output file (default: "-" for stdout)
base64: invalid option -- w
Usage:  base64 [-hvD] [-b num] [-i in_file] [-o out_file]
  -h, --help     display this message
  -D, --decode   decodes input
  -b, --break    break encoded string into num character lines
  -i, --input    input file (default: "-" for stdin)
  -o, --output   output file (default: "-" for stdout)

cc @bparees @jim-minter @csrwng

bparees commented 6 years ago

i don't think the wrapping is needed, @jim-minter ?

spadgett commented 6 years ago

Hm, it still fails for me without -w since it tries to hit an IP that is not accessible:

FAILURE after 76.000s: test/extended/clusterup.sh:186: executing 'pushd /Users/sam/go/src/github.com/openshift/origin/pkg/templateservicebroker/servicebroker/test-scripts; serviceUUID=75a70f43-dab2-11e7-9557-fec80fd78fe2 ./provision.sh' expecting success: the command returned the wrong error code
Standard output from the command:
/Users/sam/go/src/github.com/openshift/origin/pkg/templateservicebroker/servicebroker/test-scripts ~ /Users/sam/go/src/github.com/openshift/origin

[...]

curl: (3) Port number ended with ' '
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying 172.30.177.250...
* TCP_NODELAY set
  0     0    0     0    0     0      0      0 --:--:--  0:01:14 --:--:--     0* Connection failed
* connect to 172.30.177.250 port 443 failed: Operation timed out
* Failed to connect to 172.30.177.250 port 443: Operation timed out
* Closing connection 0
curl: (7) Failed to connect to 172.30.177.250 port 443: Operation timed out
[ERROR] PID 99618: hack/lib/cmd.sh:6: `return "${return_code}"` exited with status 1.

jim-minter commented 6 years ago

I didn't put the -w in there, but it's needed if requesterUsername is longer than 5 characters.
The cluster up test in question should be talking to the service catalog, not the TSB - it shouldn't be calling those test-scripts.
Are we supposed to be guaranteeing that test shell scripts run on MacOS?

jim-minter commented 6 years ago

The cluster up test in question should be talking to the service catalog, not the TSB - it shouldn't be calling those test-scripts.

https://github.com/openshift/origin/issues/17650

spadgett commented 6 years ago

I don't think this is necessary if there is no simple fix. It's still possible to run individual tests like console by passing them as args to test/extended/clusterup.sh

/close

openshift / origin

cluster up extended tests do not run on mac #17637