search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

hack/update-deps yields uncompilable results #20141

Closed bparees closed 6 years ago

bparees commented 6 years ago

hack/update-deps on master results in an unbuildable source tree. This is blocking our ability to update apis.

origin (test)$ make
hack/build-go.sh  
++ Building go targets for linux/amd64: cmd/hypershift cmd/openshift cmd/oc cmd/oadm cmd/template-service-broker cmd/openshift-node-config vendor/k8s.io/kubernetes/cmd/hyperkube pkg/network/sdn-cni-plugin vendor/github.com/containernetworking/plugins/plugins/ipam/host-local vendor/github.com/containernetworking/plugins/plugins/main/loopback
# github.com/openshift/origin/pkg/cmd/infra/router
pkg/cmd/infra/router/clientcmd.go:69:46: undefined: genericclioptions.OpenShiftKubeConfigFlagName
pkg/cmd/infra/router/clientcmd.go:70:32: undefined: genericclioptions.OpenShiftKubeConfigFlagName
# github.com/openshift/origin/pkg/oc/admin/policy
pkg/oc/admin/policy/cani.go:85:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/admin/policy/cani.go:138:18: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrinterForOptions
pkg/oc/admin/policy/cani.go:138:45: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".ExtractCmdPrintOptions
pkg/oc/admin/policy/modify_roles.go:96:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/admin/policy/modify_roles.go:135:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/admin/policy/modify_roles.go:171:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/admin/policy/modify_roles.go:209:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/admin/policy/modify_roles.go:238:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/admin/policy/modify_roles.go:270:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/admin/policy/modify_roles.go:300:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/admin/policy/modify_roles.go:300:2: too many errors
# github.com/openshift/origin/pkg/oc/admin/groups/sync/cli
pkg/oc/admin/groups/sync/cli/sync.go:180:2: undefined: util.AddPrinterFlags
pkg/oc/admin/groups/sync/cli/sync.go:432:35: undefined: util.PrintObject
# github.com/openshift/origin/pkg/oc/admin/migrate
pkg/oc/admin/migrate/migrator.go:151:2: undefined: util.AddNonDeprecatedPrinterFlags
pkg/oc/admin/migrate/migrator.go:161:19: undefined: util.PrinterForOptions
pkg/oc/admin/migrate/migrator.go:161:46: undefined: util.ExtractCmdPrintOptions
# github.com/openshift/origin/pkg/oc/cli/util/clientcmd
pkg/oc/cli/util/clientcmd/helpers.go:19:10: undefined: util.ExtractCmdPrintOptions
pkg/oc/cli/util/clientcmd/helpers.go:20:18: undefined: util.PrinterForOptions
# github.com/openshift/origin/pkg/oc/admin/node
pkg/oc/admin/node/listpods.go:26:2: undefined: util.AddPrinterFlags
pkg/oc/admin/node/node_options.go:69:21: undefined: util.PrinterForOptions
pkg/oc/admin/node/node_options.go:69:48: undefined: util.ExtractCmdPrintOptions
pkg/oc/admin/node/node_options.go:92:10: undefined: util.PrinterForOptions
pkg/oc/admin/node/node_options.go:92:37: undefined: util.ExtractCmdPrintOptions
# github.com/openshift/origin/pkg/oc/cli/cmd/create
pkg/oc/cli/cmd/create/clusterquota.go:67:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/cli/cmd/create/clusterquota.go:134:10: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrintObject
pkg/oc/cli/cmd/create/clusterquota.go:169:3: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrintSuccess
pkg/oc/cli/cmd/create/deploymentconfig.go:65:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/cli/cmd/create/deploymentconfig.go:121:10: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrintObject
pkg/oc/cli/cmd/create/deploymentconfig.go:157:3: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrintSuccess
pkg/oc/cli/cmd/create/identity.go:68:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/cli/cmd/create/identity.go:102:10: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrintObject
pkg/oc/cli/cmd/create/identity.go:144:3: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrintSuccess
pkg/oc/cli/cmd/create/imagestream.go:75:2: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".AddPrinterFlags
pkg/oc/cli/cmd/create/imagestream.go:75:2: too many errors
# github.com/openshift/origin/pkg/oc/cli/config
pkg/oc/cli/config/loader.go:12:62: undefined: genericclioptions.OpenShiftKubeConfigFlagName
pkg/oc/cli/config/loader.go:20:21: undefined: genericclioptions.OpenShiftKubeConfigFlagName
# github.com/openshift/origin/pkg/oc/admin/registry
pkg/oc/admin/registry/registry.go:495:36: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrintObject
# github.com/openshift/origin/pkg/oc/admin/router
pkg/oc/admin/router/router.go:834:36: undefined: "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util".PrintObject
# github.com/openshift/origin/pkg/oc/experimental/ipfailover
pkg/oc/experimental/ipfailover/ipfailover.go:221:37: undefined: util.PrintObject
# github.com/openshift/origin/pkg/oc/cli/cmd/importer
pkg/oc/cli/cmd/importer/appjson.go:146:45: undefined: util.PrintObject
# github.com/openshift/origin/pkg/oc/cli/secrets
pkg/oc/cli/secrets/basicauth.go:87:23: undefined: util.PrintObject
pkg/oc/cli/secrets/basicauth.go:105:2: undefined: util.AddPrinterFlags
pkg/oc/cli/secrets/dockercfg.go:87:23: undefined: util.PrintObject
pkg/oc/cli/secrets/dockercfg.go:102:2: undefined: util.AddPrinterFlags
pkg/oc/cli/secrets/new.go:97:23: undefined: util.PrintObject
pkg/oc/cli/secrets/new.go:109:2: undefined: util.AddPrinterFlags
pkg/oc/cli/secrets/sshauth.go:81:23: undefined: util.PrintObject
pkg/oc/cli/secrets/sshauth.go:98:2: undefined: util.AddPrinterFlags
# github.com/openshift/origin/pkg/oc/experimental/config
pkg/oc/experimental/config/patch.go:69:2: undefined: util.AddPrinterFlags
pkg/oc/experimental/config/patch.go:91:15: undefined: util.ExtractCmdPrintOptions
pkg/oc/experimental/config/patch.go:94:19: undefined: printers.GetStandardPrinter
[ERROR] [19:46:44-0400] PID 26848: hack/lib/build/binaries.sh:236: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${pkgdir}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" -gcflags "${gogcflags}" "${nonstatics[@]}"` exited with status 2.
[INFO] [19:46:44-0400]      Stack Trace: 
[INFO] [19:46:44-0400]        1: hack/lib/build/binaries.sh:236: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${pkgdir}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" -gcflags "${gogcflags}" "${nonstatics[@]}"`
[INFO] [19:46:44-0400]        2: hack/lib/build/binaries.sh:156: os::build::internal::build_binaries
[INFO] [19:46:44-0400]        3: hack/build-go.sh:25: os::build::build_binaries
[INFO] [19:46:44-0400]   Exiting with code 2.
[ERROR] [19:46:44-0400] PID 26776: hack/lib/build/binaries.sh:150: `( os::build::internal::build_binaries "${binaries[@]+"${binaries[@]}"}" )` exited with status 2.
[INFO] [19:46:44-0400]      Stack Trace: 
[INFO] [19:46:44-0400]        1: hack/lib/build/binaries.sh:150: `( os::build::internal::build_binaries "${binaries[@]+"${binaries[@]}"}" )`
[INFO] [19:46:44-0400]        2: hack/build-go.sh:25: os::build::build_binaries
[INFO] [19:46:44-0400]   Exiting with code 2.
[ERROR] [19:46:44-0400] hack/build-go.sh exited with code 2 after 00h 05m 34s
make: *** [Makefile:43: all] Error 2

/cc @wozniakjan @php-coder

liggitt commented 6 years ago

the bot is not able to publish out the results of the landed rebase to the openshift/kubernetes fork. errors logged in https://github.com/openshift/origin/issues/18826#issuecomment-401206051

  • /collapsed-kube-commit-mapper --commit-message-tag Origin-commit --source-branch refs/heads/upstream-branch F0628 23:48:18.545756 14725 main.go:123] Failed to map upstream branch refs/heads/upstream-branch to HEAD: no upstream mainline commit found on branch

that has to complete before updating dependencies does not drop the carries and upstreams commits required by the rebase

/assign @mfojtik @sttts

liggitt commented 6 years ago

fixed that error by pushing a correct marker commit to the upstream mainline branch. watching the bot publishing now, will update

liggitt commented 6 years ago

this is now resolved. example diff in https://github.com/openshift/origin/pull/20145

/close