openshift-ci-robot
commented
4 years ago @JacobTanenbaum: This pull request references Bugzilla bug 1787434, which is invalid:
- expected the bug to target the "3.11.z" release, but it targets "4.5.0" instead
- expected Bugzilla bug 1787434 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found
Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
In response to [this](https://github.com/openshift/origin/pull/24837):
>[release-3.11] Bug 1787434: handle pod updates correctly in networkpolicy
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
danwinship
openshift-bot
currently if there are two network policies in a namespace that match an incoming pod refreshNetworkPolicies() will only call updateNetworkPolicy() on one of them. UpdateNetworkPolicy calls parseNetworkPolicy which updates the network policy object.
removing the break in refreshNetworkPolicies() will cause updateNetworkPolicy() to be run against all changed networkpolicies which will ensure that all changed policies get successfully updated.
also updated the unit tests to expose this issue, so that this issue won't be exposed again.
4.5BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1816394 4.4BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1816392 4.3BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1816390 4.2BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1816389 4.1BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1816388 3.11BZ:https://bugzilla.redhat.com/show_bug.cgi?id=1745898