Closed sgreene570 closed 3 years ago
@sgreene570: This pull request references Bugzilla bug 1855852, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
/lgtm Thanks!
@sgreene570, #25131 got https://github.com/openshift/router/pull/127/commits/4aa8e05c8306bdbd87555447bb0cb50be819e278, and this PR gets https://github.com/openshift/router/pull/132/commits/3b287c6d70a8c4269bbc8576c4b408327c8fe5dd, but did we get https://github.com/openshift/router/pull/128/commits? I'm asking because https://github.com/openshift/router/pull/141/commits for 4.4 included all of the aforementioned commits.
@sgreene570 did we get https://github.com/openshift/router/pull/128/commits?
Looks like we did not. Shall I add those commits here ?
Amended this PR to include https://github.com/openshift/router/pull/128/commits for backporting.
/retest
/retest
test failures may have been resolved by recent CI fixes /retest
/lgtm
/assign @knobunc /retest
/approve
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
/retest
Please review the full test history for this PR and help us cut down flakes.
This is the 3.11.z backport of https://github.com/openshift/router/pull/132
When no servers are exposed, backend metrics are needed to see how many requests are making it to a service. If we don't report them users can't see when no pods are up (a crashlooping service for instance would have no metrics at all because no pods are ready). Always report all backend metrics. Increases cardinality by O(routes), but prometheus is a lot faster now.