openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

[release-3.11] Bug 1855852: Backport HAProxy report all backend metrics #25271

Closed sgreene570 closed 3 years ago

sgreene570 commented 3 years ago

This is the 3.11.z backport of https://github.com/openshift/router/pull/132

When no servers are exposed, backend metrics are needed to see how many requests are making it to a service. If we don't report them users can't see when no pods are up (a crashlooping service for instance would have no metrics at all because no pods are ready). Always report all backend metrics. Increases cardinality by O(routes), but prometheus is a lot faster now.

openshift-ci-robot commented 3 years ago

@sgreene570: This pull request references Bugzilla bug 1855852, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (3.11.z) matches configured target release for branch (3.11.z) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/origin/pull/25271): >[release-3.11] Bug 1855852: Backport HAProxy report all backend metrics Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Miciah commented 3 years ago

/lgtm Thanks!

Miciah commented 3 years ago

@sgreene570, #25131 got https://github.com/openshift/router/pull/127/commits/4aa8e05c8306bdbd87555447bb0cb50be819e278, and this PR gets https://github.com/openshift/router/pull/132/commits/3b287c6d70a8c4269bbc8576c4b408327c8fe5dd, but did we get https://github.com/openshift/router/pull/128/commits? I'm asking because https://github.com/openshift/router/pull/141/commits for 4.4 included all of the aforementioned commits.

sgreene570 commented 3 years ago

@sgreene570 did we get https://github.com/openshift/router/pull/128/commits?

Looks like we did not. Shall I add those commits here ?

sgreene570 commented 3 years ago

Amended this PR to include https://github.com/openshift/router/pull/128/commits for backporting.

sgreene570 commented 3 years ago

/retest

sgreene570 commented 3 years ago

/retest

sgreene570 commented 3 years ago

test failures may have been resolved by recent CI fixes /retest

Miciah commented 3 years ago

/lgtm

sgreene570 commented 3 years ago

/assign @knobunc /retest

knobunc commented 3 years ago

/approve

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.