search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

Bug 1866789: Remove problematic upstream client plugin test #25383

Closed akram closed 3 years ago

akram commented 3 years ago

@waveywaves @jkhelil fyi

openshift-ci-robot commented 3 years ago

@akram: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/origin/pull/25383): >Remove problematic upstream client plugin test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
akram commented 3 years ago

Blocks https://github.com/openshift/jenkins/pull/1107

akram commented 3 years ago

/retitle Bug 1866789: Remove problematic upstream client plugin test

openshift-ci-robot commented 3 years ago

@akram: This pull request references Bugzilla bug 1866789, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (3.11.z) matches configured target release for branch (3.11.z) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/origin/pull/25383): >Bug 1866789: Remove problematic upstream client plugin test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
akram commented 3 years ago

/assign gabemontero

akram commented 3 years ago

/test unit

gabemontero commented 3 years ago

@akram .... do you envision ever updating jenkins client plugin for 3.11 moving forward?

The client plugin e2e's I added in https://github.com/openshift/release/tree/master/ci-operator/jobs/openshift/jenkins-client-plugin technically only validate against OCP 4.x

I'm fine with merging this to unblock say jenkins core/dependent plugin security fixes, but IF you ever updating the client plugin on 3.11 (I personally think you should NOT because 3.11 is EOL .... only consider it if some major security flaw is identified), then either you guys have to validate it manually and hope for the best, or you create a 3.11 branch for client plugin based on whatever commit level is shipped there and create 3.11 versions of the plugin e2e's like what you see at https://github.com/openshift/release/tree/master/ci-operator/jobs/openshift/origin

Again, I think that is overkill, but want to make sure you are fully aware of the implications of removing this test here.

akram commented 3 years ago

for extended_builds there are panic on many kubectl calls:

    error running &{/usr/bin/kubectl [kubectl --server=https://internal-api.ci-op-2lh6q0il-7a04a.origin-ci-int-gce.dev.rhcloud.com:8443 --kubeconfig=/tmp/admin.kubeconfig exec --namespace=e2e-tests-persistent-local-volumes-test-9lqtf security-context-98786517-d7f4-11ea-a277-0a580a830036 -- /bin/sh -c cat /mnt/volume1/test-file] []  <nil>  runtime/cgo: pthread_create failed: Resource temporarily unavailable
    SIGABRT: abort
    PC=0x7f04c93e8387 m=9 sigcode=18446744073709551610

looks like a flake

/test extended_builds

akram commented 3 years ago

/test e2e-gcp /test unit

akram commented 3 years ago

@akram .... do you envision ever updating jenkins client plugin for 3.11 moving forward?

The client plugin e2e's I added in https://github.com/openshift/release/tree/master/ci-operator/jobs/openshift/jenkins-client-plugin technically only validate against OCP 4.x

I'm fine with merging this to unblock say jenkins core/dependent plugin security fixes, but IF you ever updating the client plugin on 3.11 (I personally think you should NOT because 3.11 is EOL .... only consider it if some major security flaw is identified), then either you guys have to validate it manually and hope for the best, or you create a 3.11 branch for client plugin based on whatever commit level is shipped there and create 3.11 versions of the plugin e2e's like what you see at https://github.com/openshift/release/tree/master/ci-operator/jobs/openshift/origin

Again, I think that is overkill, but want to make sure you are fully aware of the implications of removing this test here.

@gabemontero indeed, we will do the validations manually. The process gets more and more complex for us to deliver fixes for cve's. We cannot afford to have distinct branches for this plugins of for tests now.

gabemontero commented 3 years ago

/lgtm

I'm only a reviewer in 3.11 @akram

we'll need an approver from the OWNERS file

/assign @bparees

bparees commented 3 years ago

/approve

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

akram commented 3 years ago

/hold

akram commented 3 years ago

/test unit

akram commented 3 years ago

unit task now failing with:

[INFO] hack/build-go.sh exited with code 0 after 00h 00m 05s
FAIL: github.com/openshift/origin/pkg/build/builder TestDockerfilePath 20ms
FAIL: github.com/openshift/origin/pkg/build/builder TestDockerfileFromScratch 10ms
FAIL: github.com/openshift/origin/pkg/build/builder TestDockerBuildError 0s
FAIL: github.com/openshift/origin/pkg/build/builder TestPushError 0s
FAIL: github.com/openshift/origin/pkg/build/builder TestGetStrategyError 0s

Only these 5 tests related to Docker fails. Another empty commit PR seems to show the same error. A previous test was failing with:

FAIL: github.com/openshift/origin/pkg/build/builder TestDockerfilePath 10ms
FAIL: github.com/openshift/origin/pkg/build/builder TestDockerfileFromScratch 0s
FAIL: github.com/openshift/origin/pkg/build/builder TestDockerBuildError 0s
FAIL: github.com/openshift/origin/pkg/build/builder TestPushError 0s
FAIL: github.com/openshift/origin/pkg/build/builder TestGetStrategyError 0s
FAIL: github.com/openshift/origin/pkg/network/node TestEgressVXLANMonitor 10ms

Re-running all the others .

/retest

akram commented 3 years ago

/retest

akram commented 3 years ago

RHEL repository flake:

leveldb-1.12.0-5.el7.1.x86_64: [Errno 256] No more mirrors to try.

/test e2e-gcp

akram commented 3 years ago

/retest

akram commented 3 years ago

/test images

flake again and over again

akram commented 3 years ago 
2:python-rados-12.2.11-0.el7.x86_64: [Errno 256] No more mirrors to try.

/test e2e-gcp

akram commented 3 years ago

/retest

akram commented 3 years ago

/retest

akram commented 3 years ago

/hold cancel

akram commented 3 years ago

/retest

waveywaves commented 3 years ago

/retest

waveywaves commented 3 years ago

/retest

openshift-ci-robot commented 3 years ago

@akram: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_builds 4fe5abe4af2f8cdb9662476d78dc4b36503bb892 link /test extended_builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
squeed commented 3 years ago

/uncc

mtnbikenc commented 3 years ago

Ignore me. /test extended_builds

gabemontero commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/build/OWNERS](https://github.com/openshift/origin/blob/release-3.11/pkg/build/OWNERS)~~ [bparees] - ~~[test/extended/OWNERS](https://github.com/openshift/origin/blob/release-3.11/test/extended/OWNERS)~~ [bparees] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mtnbikenc commented 3 years ago

/test extended_builds

mtnbikenc commented 3 years ago

/test extended_builds