openshift-ci-robot
commented
3 years ago @Miciah: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.
In response to [this](https://github.com/openshift/origin/pull/25578):
>Bugs 1884421, 1884422: Backport router hostindex fixes
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Miciah
sgreene570
frobware
openshift-bot
Backport https://github.com/openshift/router/pull/57, https://github.com/openshift/router/pull/59, and https://github.com/openshift/router/pull/126 (modulo potentially incompatible changes related to unit tests).
hostindex: Passthrough displaces path-based TLS
Ensure that a passthrough route displaces any path-based TLS routes with the same host, because passthrough is incompatible with path-based routing.
pkg/router/controller/hostindex/activation.go(hasExistingMatch): Return true if both routes are TLS and the existing route is a passthrough route.pkg/router/controller/hostindex/hostindex_test.go(Test_hostIndex): Verify that a passthrough route displaces path-based TLS routes with the same host, but does not displace non-TLS routes.hostindex: Path-based TLS displaces passthrough
Just as a passthrough route displaces any path-based TLS routes with the same host, a path-based TLS route displaces any passthrough route with the same host.
pkg/router/controller/hostindex/activation.go(hasExistingMatch): Return true if both routes are TLS and either route is passthrough.pkg/router/controller/hostindex/hostindex_test.go(Test_hostIndex): Verify that a path-based TLS route displaces passthrough routes with the same host.Try to promote inactive routes following route deletion
Before this patch, inactive routes were not being promoted when the conflicting routes were deleted. Fix it so that when deletes happen, all inactive routes are given a chance to be promoted.