openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.47k stars 4.69k forks source link

Need independent access mode parameters for different volume type in manifest for CSI badge e2e tests #28377

Closed akshay-nim closed 3 months ago

akshay-nim commented 8 months ago
Description :

This issue is regarding manifest.yaml file which we use for csi certification testing. Currently If we pass supported acces modes in manifest.yaml and block volume is true :
RequiredAccessModes: ["ReadWriteMany","ReadOnlyMany", "ReadWriteOnce"]

This will apply these access mode for both filesystem and block volumes or ephemral volumes. there is another concern aligned to this enhancement is that if we dont mention RWO access mode in "RequiredAccessMode" parameter, badge/certification testing still runs test with RWO access mode

In our case we want Independendt access mode parameters for different volume types. This will help in scenario where we want to support some access mode for block volume or some access mode for epheremral volume .

Version

Client Version: 4.12.37 Kustomize Version: v4.5.7 Server Version: 4.12.37 Kubernetes Version: v1.25.12+ba5cc25

Sample manifest.yaml parameters that we use

Optional list of access modes required for provisiong. Default is RWO

RequiredAccessModes: ["ReadWriteMany","ReadOnlyMany"]

Map that represents the capabilities the driver supports

Capabilities:

Data is persistest accross pod restarts

persistence: true

# Volume ownership via fsGroup
fsGroup: true

ephemeral: true
multipods: true
# Raw block mode
block: true

# Exec a file in the volume
exec: true

# Support for volume limits
volumeLimits: false

# Support for volume expansion in controllers
controllerExpansion: true

# Support for volume expansion in nodes
nodeExpansion: true

# Support volume that an run on single node only (like hostpath)
singleNodeVolume: false

# Support ReadWriteMany access modes
RWX: true

# Support topology
topology: false

# Support populate data from snapshot
snapshotDataSource: true

# Support populated data from PVC
pvcDataSource: true
Current Result

Mentioned Access modes in manifest applied for block volume as well

Expected Result

we want to support 3 access mode : RWO, RWX,ROM for filesystem vol and 2 access mode for block volume

Additional Information
openshift-bot commented 5 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 3 months ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/origin/issues/28377#issuecomment-2031329717): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.