openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

API-1802: watchevents: add cert rotation events #28639

Open vrutkovs opened 2 months ago

vrutkovs commented 2 months ago

library-go emits events when cert rotation happens, these should be displayed as interesting events.

Example, filter by Interesting Events

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

@vrutkovs: This pull request references API-1802 which is a valid jira issue.

In response to [this](https://github.com/openshift/origin/pull/28639): >library-go emits events when cert rotation happens, these should be displayed as interesting events. > >[Example](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-gcp-modern/1780541177255170048/artifacts/launch/openshift-e2e-test/artifacts/junit/e2e-timelines_everything_20240417-115106.html), filter by Interesting Events Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vrutkovs commented 2 weeks ago

/retest

openshift-ci[bot] commented 2 weeks ago

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 966e9c8254c3df5e3638c528e255998e51e21b3f link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade 966e9c8254c3df5e3638c528e255998e51e21b3f link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-trt-bot commented 2 weeks ago

Job Failure Risk Analysis for sha: 966e9c8254c3df5e3638c528e255998e51e21b3f

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Low
[sig-arch] events should not repeat pathologically for ns/openshift-etcd
This test has passed 77.78% of 45 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node'] in the last 14 days.