openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

OCPBUGS-30267: Clarify a misleading message in patho event failures #28667

Closed dgoodwin closed 1 month ago

dgoodwin commented 1 month ago

We were outputting From: To: timestamps, which was always 1s implying the event happened 20+ times in a second, which was entirely untrue. We don't really know the start time for the event, and even the observed time is a little sketchy. Switch to just showing the time we received the event with the count being displayed for now.

openshift-ci-robot commented 1 month ago

@dgoodwin: This pull request references Jira Issue OCPBUGS-30267, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/28667): >We were outputting From: To: timestamps, which was always 1s implying >the event happened 20+ times in a second, which was entirely untrue. We >don't really know the start time for the event, and even the observed >time is a little sketchy. Switch to just showing the time we received >the event with the count being displayed for now. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
neisw commented 1 month ago

/lgtm

At some point we may want to at least preserve / record the original From time on the incoming kube event. But doesn't have to be now.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [dgoodwin,neisw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 6632b4ab46e9d179bd0d28d6853690e410079e5a and 2 for PR HEAD efb5a104f7d74ab9cd252893296ad729125ac9f2 in total

dgoodwin commented 1 month ago

Yes that would be nice, it's going to get a little tricky I think, it could have occurred before we were even watching, but we could modify this whole stack to track each unique message, each time it came in, the count number, and then subtract the largest count from the initial count we saw and do something with that perhaps.

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 0d6231f801b696aefb1c5b82a0949c9c1945a048 and 1 for PR HEAD efb5a104f7d74ab9cd252893296ad729125ac9f2 in total

openshift-ci[bot] commented 1 month ago

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial efb5a104f7d74ab9cd252893296ad729125ac9f2 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn efb5a104f7d74ab9cd252893296ad729125ac9f2 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade efb5a104f7d74ab9cd252893296ad729125ac9f2 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3515349dbb6558a379d125b11f0d25b22e1ab641 and 0 for PR HEAD efb5a104f7d74ab9cd252893296ad729125ac9f2 in total

openshift-ci-robot commented 1 month ago

@dgoodwin: Jira Issue OCPBUGS-30267: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30267 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin/pull/28667): >We were outputting From: To: timestamps, which was always 1s implying >the event happened 20+ times in a second, which was entirely untrue. We >don't really know the start time for the event, and even the observed >time is a little sketchy. Switch to just showing the time we received >the event with the count being displayed for now. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403280418.p0.gb9599f4.assembly.stream.el8 for distgit openshift-enterprise-tests. All builds following this will include this PR.