Closed dgoodwin closed 1 month ago
@dgoodwin: This pull request references Jira Issue OCPBUGS-30267, which is valid. The bug has been moved to the POST state.
The bug has been updated to refer to the pull request using the external bug tracker.
/lgtm
At some point we may want to at least preserve / record the original From time on the incoming kube event. But doesn't have to be now.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgoodwin, neisw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 6632b4ab46e9d179bd0d28d6853690e410079e5a and 2 for PR HEAD efb5a104f7d74ab9cd252893296ad729125ac9f2 in total
Yes that would be nice, it's going to get a little tricky I think, it could have occurred before we were even watching, but we could modify this whole stack to track each unique message, each time it came in, the count number, and then subtract the largest count from the initial count we saw and do something with that perhaps.
/retest-required
Remaining retests: 0 against base HEAD 0d6231f801b696aefb1c5b82a0949c9c1945a048 and 1 for PR HEAD efb5a104f7d74ab9cd252893296ad729125ac9f2 in total
@dgoodwin: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-aws-ovn-single-node-serial | efb5a104f7d74ab9cd252893296ad729125ac9f2 | link | false | /test e2e-aws-ovn-single-node-serial |
ci/prow/e2e-metal-ipi-sdn | efb5a104f7d74ab9cd252893296ad729125ac9f2 | link | false | /test e2e-metal-ipi-sdn |
ci/prow/e2e-aws-ovn-single-node-upgrade | efb5a104f7d74ab9cd252893296ad729125ac9f2 | link | false | /test e2e-aws-ovn-single-node-upgrade |
Full PR test history. Your PR dashboard.
/retest-required
Remaining retests: 0 against base HEAD 3515349dbb6558a379d125b11f0d25b22e1ab641 and 0 for PR HEAD efb5a104f7d74ab9cd252893296ad729125ac9f2 in total
@dgoodwin: Jira Issue OCPBUGS-30267: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-30267 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403280418.p0.gb9599f4.assembly.stream.el8 for distgit openshift-enterprise-tests. All builds following this will include this PR.
We were outputting From: To: timestamps, which was always 1s implying the event happened 20+ times in a second, which was entirely untrue. We don't really know the start time for the event, and even the observed time is a little sketchy. Switch to just showing the time we received the event with the count being displayed for now.