search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

OSD-21708: Skip managed services pods that have limits but not requests #28668

Open stbenjam opened 1 month ago

stbenjam commented 1 month ago

Managed service pods are setting hard limits, instead of requests, contrary to OCP conventions. Ref: https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits

OSD-21708 tracks fixing these pods, meanwhile add exceptions so the test passes.

openshift-ci-robot commented 1 month ago

@stbenjam: This pull request references OSD-21708 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/28668): >[OSD-21708](https://issues.redhat.com//browse/OSD-21708) tracks fixing these pods, meanwhile add exceptions so the test passes. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@stbenjam: This pull request references OSD-21708 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/28668): >[OSD-21708](https://issues.redhat.com//browse/OSD-21708) tracks fixing these pods, meanwhile add exceptions so the test passes. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@stbenjam: This pull request references OSD-21708 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/28668): >Managed service pods are setting hard limits, instead of requests, contrary to OCP conventions. Ref: https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits > >[OSD-21708](https://issues.redhat.com//browse/OSD-21708) tracks fixing these pods, meanwhile add exceptions so the test passes. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dgoodwin commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/operators/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/operators/OWNERS)~~ [dgoodwin,stbenjam] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 6632b4ab46e9d179bd0d28d6853690e410079e5a and 2 for PR HEAD 437457d6f44d050b0535fd66026f7ebc20357134 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 0d6231f801b696aefb1c5b82a0949c9c1945a048 and 1 for PR HEAD 437457d6f44d050b0535fd66026f7ebc20357134 in total

stbenjam commented 1 month ago

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Metal failure is unrelated

openshift-ci[bot] commented 1 month ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to [this](https://github.com/openshift/origin/pull/28668#issuecomment-2021739452): >/override ci/prow/e2e-metal-ipi-ovn-ipv6 > >Metal failure is unrelated Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stbenjam commented 1 month ago

/hold

Will update this to do it a little differently

openshift-ci[bot] commented 1 week ago

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 437457d6f44d050b0535fd66026f7ebc20357134 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-fips 437457d6f44d050b0535fd66026f7ebc20357134 link unknown /test e2e-aws-ovn-fips
ci/prow/e2e-aws-csi 437457d6f44d050b0535fd66026f7ebc20357134 link false /test e2e-aws-csi
ci/prow/e2e-aws-ovn-single-node-serial 437457d6f44d050b0535fd66026f7ebc20357134 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-upgrade 437457d6f44d050b0535fd66026f7ebc20357134 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 437457d6f44d050b0535fd66026f7ebc20357134 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade 437457d6f44d050b0535fd66026f7ebc20357134 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-sdn 437457d6f44d050b0535fd66026f7ebc20357134 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-edge-zones 437457d6f44d050b0535fd66026f7ebc20357134 link true /test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-trt-bot commented 1 week ago

Job Failure Risk Analysis for sha: 437457d6f44d050b0535fd66026f7ebc20357134

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 High
[sig-api-machinery] disruption/oauth-api connection/new should be available throughout the test
This test has passed 100.00% of 9 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-ipv6' 'periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6'] in the last 14 days.