openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

OCPBUGS-31484: Use centos7 tag instead of latest for cmd images tests #28675

Closed ardaguclu closed 1 month ago

ardaguclu commented 1 month ago

Images' latest tag and auto built mechanisms have been permanently disabled in quay.io/centos7 repository. This PR modifies these images to use centos7 tag instead of latest. So that cmd/images.sh tests will continue passing.

But there is no indication whether, at some point in the future, these images or this tag will be removed also or not. I try to remove unit tests entirely to overcome this issue https://github.com/openshift/oc/pull/1717 but maybe for e2e tests, we can give one more try to continue with centos7 tag, until it is removed.

openshift-ci-robot commented 1 month ago

@ardaguclu: This pull request references Jira Issue OCPBUGS-31484, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (aos-workloads-staff@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/28675): >Images' `latest` tag and auto built mechanisms have been permanently disabled in `quay.io/centos7` repository. >This PR modifies these images to use `centos7` tag instead of latest. So that cmd/images.sh tests will continue passing. > >But there is no indication whether, at some point in the future, these images or this tag will be removed also or not. I try to remove unit tests entirely to overcome this issue https://github.com/openshift/oc/pull/1717 but maybe for e2e tests, we can give one more try to continue with `centos7` tag, until it is removed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu, soltysh Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[examples/image-streams/OWNERS](https://github.com/openshift/origin/blob/master/examples/image-streams/OWNERS)** - ~~[test/OWNERS](https://github.com/openshift/origin/blob/master/test/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
soltysh commented 1 month ago

/label approve

openshift-ci[bot] commented 1 month ago

@soltysh: The label(s) /label approve cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to [this](https://github.com/openshift/origin/pull/28675#issuecomment-2024907139): >/label approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ardaguclu commented 1 month ago

@bparees could you please take a look at this?. Thanks.

openshift-ci[bot] commented 1 month ago

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 3d307aa16055b7f657817961a378f4b35ea2baeb link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade 3d307aa16055b7f657817961a378f4b35ea2baeb link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 3d307aa16055b7f657817961a378f4b35ea2baeb link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn 3d307aa16055b7f657817961a378f4b35ea2baeb link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
soltysh commented 1 month ago

/label approved

openshift-ci-robot commented 1 month ago

@ardaguclu: Jira Issue OCPBUGS-31484: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-31484 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin/pull/28675): >Images' `latest` tag and auto built mechanisms have been permanently disabled in `quay.io/centos7` repository. >This PR modifies these images to use `centos7` tag instead of latest. So that cmd/images.sh tests will continue passing. > >But there is no indication whether, at some point in the future, these images or this tag will be removed also or not. I try to remove unit tests entirely to overcome this issue https://github.com/openshift/oc/pull/1717 but maybe for e2e tests, we can give one more try to continue with `centos7` tag, until it is removed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403281444.p0.g8b3dee6.assembly.stream.el8 for distgit openshift-enterprise-tests. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.16.0-0.nightly-2024-03-28-223620

sanchezl commented 4 weeks ago

This should be back-ported.

ardaguclu commented 3 weeks ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 3 weeks ago

@ardaguclu: new pull request created: #28688

In response to [this](https://github.com/openshift/origin/pull/28675#issuecomment-2036147916): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.