openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

no-jira: Ignore alerts on CustomNoUpgrade clusters #28678

Closed patrickdillon closed 3 weeks ago

patrickdillon commented 1 month ago

This updates a helper function to check for both CustomNoUpgrade and TechPreviewNoUpgrade when determining whether non-upgradeable alerts should be ignored.

Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8162/pull-ci-openshift-installer-master-altinfra-e2e-aws-capi-ovn/1768648527321239552

patrickdillon commented 1 month ago

/cc @gabemontero To ensure it's safe to act on the TODOs

stbenjam commented 4 weeks ago

/approve

openshift-trt-bot commented 4 weeks ago

Job Failure Risk Analysis for sha: 4cd0692878d1cc75fda9f0dcf492b0ab2aa5e901

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Low
[sig-arch] events should not repeat pathologically for ns/openshift-etcd-operator
This test has passed 28.38% of 74 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.
openshift-ci-robot commented 4 weeks ago

@patrickdillon: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/28678): >This updates a helper function to check for both CustomNoUpgrade and TechPreviewNoUpgrade when determining whether non-upgradeable alerts should be ignored. > >Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8162/pull-ci-openshift-installer-master-altinfra-e2e-aws-capi-ovn/1768648527321239552 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
patrickdillon commented 4 weeks ago

/retest

openshift-ci[bot] commented 4 weeks ago

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 4cd0692878d1cc75fda9f0dcf492b0ab2aa5e901 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 4cd0692878d1cc75fda9f0dcf492b0ab2aa5e901 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn 4cd0692878d1cc75fda9f0dcf492b0ab2aa5e901 link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
patrickdillon commented 3 weeks ago

@stbenjam these test failures do not seem related to my PR. not sure if I should spend $$ spinning retests to see if they pass?

patrickdillon commented 3 weeks ago

/cc @deads2k

stbenjam commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/openshift/origin/blob/master/test/OWNERS)~~ [stbenjam] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 1972e661e54566cecbcbf9c3835d5313e6ad7cd4 and 2 for PR HEAD 4cd0692878d1cc75fda9f0dcf492b0ab2aa5e901 in total

openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202404091010.p0.g856924d.assembly.stream.el8 for distgit openshift-enterprise-tests. All builds following this will include this PR.