search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

OCPBUGS-31030, OCPBUGS-31032: Reduce deploymentconfig test 3GBi memory size to reasonable #28680

Closed ardaguclu closed 1 week ago

ardaguclu commented 4 weeks ago

tools:latest image takes 922792256 bytes (i.e. ~1GBi). So that there is no reason to allocate memory size to 3Gi, besides this test fails on the cluster having limited resources. This PR reduces the allocated memory size to 1.4Gi. This value has been chosen to have a safety gap in the cases where tools image's size is increased.

Moreover, there are numerous deploymentconfig deprecated warnings stemming from deploymentconfig status check function that is executed per 200ms, this PR increases period to 500ms in order to reduce the count of warning messages.

openshift-ci-robot commented 4 weeks ago

@ardaguclu: This pull request references Jira Issue OCPBUGS-31032, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/28680): >`tools:latest` image takes 922792256 bytes (i.e. ~1GBi). On the other hand, `registry.redhat.io/ubi8/ubi:latest` image takes ~75MBi. Deployment test only tries to sleep pre-determined amount of time and there is no need to use `tools` image. So that this PR switches to `ubi8` and reduces memory size to 512MBi (to have a safety gap for the cases where ubi8 will increase in the future). > >Moreover, there are numerous deploymentconfig deprecated warnings stemming from deploymentconfig status check function which is executed per 200ms, this PR increases period to 500ms in order to reduce the count of warning messages. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 4 weeks ago

/jira refresh

openshift-ci-robot commented 4 weeks ago

@ardaguclu: This pull request references Jira Issue OCPBUGS-31032, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
In response to [this](https://github.com/openshift/origin/pull/28680#issuecomment-2031184846): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 weeks ago

@ardaguclu: This pull request references Jira Issue OCPBUGS-31032, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
In response to [this](https://github.com/openshift/origin/pull/28680): >`tools:latest` image takes 922792256 bytes (i.e. ~1GBi). So that there is no reason to allocate memory size to 3Gi, besides this test fails on the cluster having limited resources. This PR reduces the allocated memory size to 1.4Gi. This value has been chosen to have a safety gap in the cases where tools image's size is increased. > >Moreover, there are numerous deploymentconfig deprecated warnings stemming from deploymentconfig status check function that is executed per 200ms, this PR increases period to 500ms in order to reduce the count of warning messages. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 4 weeks ago

/retest

ardaguclu commented 3 weeks ago

@ingvagabund does this change make sense?. It seems to be safe to me but I'd like to ensure that not causing any issues.

ingvagabund commented 3 weeks ago

Worth trying how this goes. /approve /lgtm

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD eb644830609d73fa67a802f44f72412b405bf455 and 2 for PR HEAD a16072fdbe28b3ca9816ef85537971b5eabc0996 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 34cefb10bd528819c6cc33b974f2792f9635ac0f and 1 for PR HEAD a16072fdbe28b3ca9816ef85537971b5eabc0996 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 065d051bb9a2b33751ee77dc48b07b2bd0f60522 and 0 for PR HEAD a16072fdbe28b3ca9816ef85537971b5eabc0996 in total

openshift-ci-robot commented 1 week ago

/hold

Revision a16072fdbe28b3ca9816ef85537971b5eabc0996 was retested 3 times: holding

ardaguclu commented 1 week ago

/hold cancel /retest-required

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD f80fe23fe062999a5625a3079fcd6d1987ea0cfc and 2 for PR HEAD a16072fdbe28b3ca9816ef85537971b5eabc0996 in total

openshift-trt-bot commented 1 week ago

Job Failure Risk Analysis for sha: a16072fdbe28b3ca9816ef85537971b5eabc0996

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (23) are below the historical average (906): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
ardaguclu commented 1 week ago

/retest

openshift-ci[bot] commented 1 week ago

@ardaguclu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade a16072fdbe28b3ca9816ef85537971b5eabc0996 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@ardaguclu: Jira Issue OCPBUGS-31032: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31032 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin/pull/28680): >`tools:latest` image takes 922792256 bytes (i.e. ~1GBi). So that there is no reason to allocate memory size to 3Gi, besides this test fails on the cluster having limited resources. This PR reduces the allocated memory size to 1.4Gi. This value has been chosen to have a safety gap in the cases where tools image's size is increased. > >Moreover, there are numerous deploymentconfig deprecated warnings stemming from deploymentconfig status check function that is executed per 200ms, this PR increases period to 500ms in order to reduce the count of warning messages. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202404201710.p0.g28ea635.assembly.stream.el8 for distgit openshift-enterprise-tests. All builds following this will include this PR.