openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

openshift-tests command failed to run without FeatureGate filter in dryRun #28681

Closed Rajalakshmi-Girish closed 2 months ago

Rajalakshmi-Girish commented 7 months ago

openshift-tests command failed to run without FeatureGate filter in dryRun

Version

As we are intending to do a dry run, the version shouldn't be necessary.

Steps To Reproduce

Have golang installed

  1. Clone openshift/origin repo
  2. Run make GO_REQUIRED_MIN_VERSION:= WHAT=cmd/openshift-tests to build openshift-tests binary
  3. cp ./openshift-tests /usr/local/bin
  4. Run command openshift-tests run kubernetes/conformance --dry-run
Current Result
+ openshift-tests run kubernetes/conformance --dry-run
Unable to get admin rest config, skipping apigroup check in the dry-run mode: could not load client configuration: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
time="2024-03-29T02:18:52Z" level=info msg="Decoding provider" clusterState="<nil>" discover=true dryRun=true func=DecodeProvider providerType=
  W0329 02:18:52.866818      13 test_context.go:547] Unable to find in-cluster config, using default host : https://127.0.0.1:6443
Unable to get server version through discovery client, skipping apigroup check in the dry-run mode: <nil>
error converting to options: unable to build FeatureGate filter: Get "http://localhost/apis/config.openshift.io/v1/featuregates/cluster": dial tcp [::1]:80: connect: connection refusederror: unable to build FeatureGate filter: Get "http://localhost/apis/config.openshift.io/v1/featuregates/cluster": dial tcp [::1]:80: connect: connection refused
Expected Result

Should list the tests.

Rajalakshmi-Girish commented 7 months ago

This started occurring after https://github.com/openshift/origin/pull/28670/commits/8207a5406e7138c75f35425e3646c8cdf3e92c8a @deads2k Can you please check?

vrutkovs commented 7 months ago

I think this is intentional - test list in the suite depends on the enabled features and may vary. We could make it skip this check and assume no feature gates are enabled, but in that case the output would miss some tests

Rajalakshmi-Girish commented 7 months ago

I think this is intentional - test list in the suite depends on the enabled features and may vary. We could make it skip this check and assume no feature gates are enabled, but in that case the output would miss some tests

Thanks for the reply. But how do you think dry-run command be used? Is there a flag that I am missing when I run openshift-tests run kubernetes/conformance --dry-run

openshift-bot commented 4 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 2 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 2 months ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/origin/issues/28681#issuecomment-2324070818): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.