openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

AUTH-509: Remove `system:anonymous` test cases #28686

Closed ibihim closed 6 days ago

ibihim commented 4 weeks ago

What

Remove system:anonymous test cases as the unauthenticated user group isn't able to make selfsubjectaccessreviews any more.

Why

With AUTH 509, we are removing unauthenticed user group from every role binding, making it impossible for system:anonymous to make a selfsubjectaccessreviews any more.

Ref

openshift-ci-robot commented 4 weeks ago

@ibihim: This pull request references AUTH-509 which is a valid jira issue.

In response to [this](https://github.com/openshift/origin/pull/28686): >## What > >Remove `system:anonymous` test cases as the unauthenticated user group isn't able to make selfsubjectaccessreviews any more. > >## Why > >With AUTH 509, we are removing unauthenticed user group from every role binding, making it impossible for system:anonymous to make a selfsubjectaccessreviews any more. > >## Ref > >- [Removal from cluster role bindings](https://github.com/openshift/openshift-apiserver/pull/423) >- [Failing tests](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_openshift-apiserver/423/pull-ci-openshift-openshift-apiserver-master-e2e-aws-ovn/1775108232595902464) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 weeks ago

@ibihim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 33b31016356269753d0f0b360806db738b01855f link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial 33b31016356269753d0f0b360806db738b01855f link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 33b31016356269753d0f0b360806db738b01855f link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node 33b31016356269753d0f0b360806db738b01855f link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ibihim commented 3 weeks ago

/retest-required

ibihim commented 3 weeks ago

/retest-required

ibihim commented 2 weeks ago

/retest-required

ibihim commented 2 weeks ago

/retest-required

ibihim commented 2 weeks ago

/retest-required

stlaz commented 1 week ago

/hold this is wrong

deads2k commented 1 week ago

/hold

this is bugged.

deads2k commented 1 week ago

I'm pursuaded.

/lgtm /approve /hold cancel

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/authorization/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/authorization/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stlaz commented 1 week ago

/hold cancel On a second look, it's probably actually really testing SARs.

openshift-bot commented 6 days ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202404251110.p0.g738fd8c.assembly.stream.el9 for distgit openshift-enterprise-tests. All builds following this will include this PR.