openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

NO-JIRA: add service accounts to resourcewatcher #28689

Closed deads2k closed 3 weeks ago

deads2k commented 3 weeks ago

so we can debug when particular imagepullsecrets were added.

rphillips commented 3 weeks ago

This will help debugging a problem within the kubelet in regards to pods starting, and not getting pull secrets updated.

/lgtm

neisw commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, neisw, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [neisw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rphillips commented 3 weeks ago

/retitle NO-JIRA: add service accounts to resourcewatcher

openshift-ci-robot commented 3 weeks ago

@deads2k: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/28689): >so we can debug when particular imagepullsecrets were added. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rphillips commented 3 weeks ago

/retest-required

openshift-ci[bot] commented 3 weeks ago

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 8c27402865c58951e3c67d4a247cd6bb4acde3d8 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 8c27402865c58951e3c67d4a247cd6bb4acde3d8 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202404051443.p0.g6d7739a.assembly.stream.el8 for distgit openshift-enterprise-tests. All builds following this will include this PR.