search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

Relax job requirement for backenddisruption unit test #28690

Open DennisPeriquet opened 3 weeks ago

DennisPeriquet commented 3 weeks ago

For the unit test that this PR modifies, there are 194 jobs in the data for the testcase (which is over the original minimum jobs requirement of 100) in this version SHA of this repo (for query_results.json). In the next set of disruption data, there are only 64 jobs found. This PR relaxes the minimum job number requirement to get the unit test to pass so we can merge the new disruption data.

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [DennisPeriquet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
DennisPeriquet commented 3 weeks ago

This very small change affects only a unit test which is not testing anything new so I feel like overriding these two failing tests is justified as those failures have absolutely nothing to do with this change.

/override /test e2e-gcp-ovn-upgrade /override ci/prow/e2e-aws-ovn-serial

openshift-ci[bot] commented 3 weeks ago

@DennisPeriquet: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/origin/pull/28690#issuecomment-2038626086): >This very small change affects only a unit test which is not testing anything new so I feel like overriding these two failing tests is justified as those failures have absolutely nothing to do with this change. > >/override /test e2e-gcp-ovn-upgrade >/override ci/prow/e2e-aws-ovn-serial > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
DennisPeriquet commented 3 weeks ago

/override ci/prow/e2e-gcp-ovn-upgrade /override ci/prow/e2e-aws-ovn-serial

openshift-ci[bot] commented 3 weeks ago

@DennisPeriquet: Overrode contexts on behalf of DennisPeriquet: ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-gcp-ovn-upgrade

In response to [this](https://github.com/openshift/origin/pull/28690#issuecomment-2038626664): >/override ci/prow/e2e-gcp-ovn-upgrade >/override ci/prow/e2e-aws-ovn-serial Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 weeks ago

@DennisPeriquet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 8f825f01d692fbf2ea7f029605d7b5d85a85f046 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial 8f825f01d692fbf2ea7f029605d7b5d85a85f046 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-upgrade 8f825f01d692fbf2ea7f029605d7b5d85a85f046 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-cgroupsv2 8f825f01d692fbf2ea7f029605d7b5d85a85f046 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-metal-ipi-sdn 8f825f01d692fbf2ea7f029605d7b5d85a85f046 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade 8f825f01d692fbf2ea7f029605d7b5d85a85f046 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).