OCPBUGS-26498: Add test for UpgradeValidation contention

gcs278 commented 2 weeks ago

Add "The HAProxy router converges when multiple routers are writing conflicting upgrade validation status" test which validates router converge when writing conflicting status in a scenario that uses multiple conditions.

Testing contention at a condition-level is important because it exercises a slightly different logic path.

openshift-ci-robot commented 2 weeks ago

@gcs278: This pull request references Jira Issue OCPBUGS-26498, which is valid.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/28710): >Add "The HAProxy router converges when multiple routers are writing conflicting upgrade validation status" test which validates router converge when writing conflicting status in a scenario that uses multiple conditions. > >Testing contention at a condition-level is important because it exercises a slightly different logic path. > >WIP because I need https://github.com/openshift/router/pull/575 merged. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gcs278 Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[test/extended/router/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/router/OWNERS)** - **[test/extended/util/annotate/generated/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/util/annotate/generated/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-trt-bot commented 2 weeks ago

Job Failure Risk Analysis for sha: d40ce53206a8dc32b5421c205d93b0b606c905d3

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-fips	IncompleteTests Tests for this run (98) are below the historical average (1540): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node	Low [sig-arch] events should not repeat pathologically for ns/openshift-etcd This test has passed 77.55% of 49 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node'] in the last 14 days.

openshift-trt-bot commented 1 week ago

Job Failure Risk Analysis for sha: 4fd7700474e0c64cf6fb038b8f7938c517b00070

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade	High [sig-apps] job-upgrade This test has passed 100.00% of 27 runs on jobs ['periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-upgrade'] in the last 14 days.