search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

NO-JIRA: Create autodl file for per user resource request audit entries #28715

Closed neisw closed 1 week ago

neisw commented 2 weeks ago

Builds on https://github.com/openshift/origin/pull/28705 to create json output for bq loading

openshift-ci-robot commented 2 weeks ago

@neisw: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/28715): >Builds on https://github.com/openshift/origin/pull/28705 to create json output for bq loading Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
neisw commented 2 weeks ago

/hold

deads2k commented 2 weeks ago

code lgtm, but two possible improvements

  1. fix the TODO and skip the audit log entries outside the beginning and end (this might matter for the upgrade conformance tests)
  2. only upload users in...
    1. openshift-*
    2. kubelets
    3. kcm identity
    4. kas identity
    5. ks identity
deads2k commented 1 week ago

optional suggestion (could also do a followup)

/lgtm

deads2k commented 1 week ago

/lgtm

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [deads2k,neisw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
candita commented 1 week ago

/test unit

openshift-ci[bot] commented 1 week ago

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade b1acc0a2495e6cbd75a33e73972b77cdb27ca915 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node b1acc0a2495e6cbd75a33e73972b77cdb27ca915 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial b1acc0a2495e6cbd75a33e73972b77cdb27ca915 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-csi b1acc0a2495e6cbd75a33e73972b77cdb27ca915 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-upgrade b1acc0a2495e6cbd75a33e73972b77cdb27ca915 link false /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
neisw commented 1 week ago

/hold cancel

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD e06689a1ea032ed0dc0cf0b82ca209a3487e8271 and 2 for PR HEAD b1acc0a2495e6cbd75a33e73972b77cdb27ca915 in total