search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

OCPBUGS-32293: Update Jenkins test to use Deployment #28718

Closed apoorvajagtap closed 1 week ago

apoorvajagtap commented 2 weeks ago

Failing Jenkins Pipeline test blocks multiple PRs from merging. As agreed, skipping these tests temporarily.

openshift-ci-robot commented 2 weeks ago

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-32293, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/28718): >Failing Jenkins Pipeline test blocks multiple PRs from merging. As agreed, skipping these tests temporarily. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
apoorvajagtap commented 2 weeks ago

/assign @adambkaplan

sayan-biswas commented 2 weeks ago

/approve

sayan-biswas commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, apoorvajagtap, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/builds/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/builds/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 886b7ae2ff74fceb4dbc8675dd01882e1b294632 and 2 for PR HEAD 809e832a14e2b63b808753dd30d0f2bcdf503d78 in total

openshift-trt-bot commented 2 weeks ago

Job Failure Risk Analysis for sha: 809e832a14e2b63b808753dd30d0f2bcdf503d78

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (18) are below the historical average (741): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
openshift-ci[bot] commented 2 weeks ago

New changes are detected. LGTM label has been removed.

apoorvajagtap commented 2 weeks ago

@adambkaplan While looking through the test logs, I realized that it creates deployment (template changes introduced with 4.15) & the test waits for deploymentConfig to be ready. Instead of skipping, I have replaced the wait function, and I hope this will fix it. PTAL :)

adambkaplan commented 2 weeks ago

:thinking: Now I'm wondering why it took us this long to catch the change...

sanchezl commented 1 week ago

/retest

openshift-ci[bot] commented 1 week ago

@apoorvajagtap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial ba2a8f06e34c88f55e547b21fe2827b9a8f2e224 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-ovn-builds ba2a8f06e34c88f55e547b21fe2827b9a8f2e224 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-single-node-upgrade ba2a8f06e34c88f55e547b21fe2827b9a8f2e224 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-trt-bot commented 1 week ago

Job Failure Risk Analysis for sha: ba2a8f06e34c88f55e547b21fe2827b9a8f2e224

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Low
[sig-arch] events should not repeat pathologically for ns/openshift-etcd-operator
This test has passed 49.30% of 71 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.
soltysh commented 1 week ago

Found the culprit in https://github.com/openshift/cluster-samples-operator/pull/540, so yes, aside from that wait, you need to update that run as I mentioned above.

Also, given we have those two extra places which don't seem to be in-sync with what we have in samples, I'd suggest to sync them as well. To make them all consistent.

soltysh commented 1 week ago

/approve cancel Please ping me directly on slack once all of the above is fixed, I don't want to have a half baked solution.

soltysh commented 1 week ago

Also DumpApplicationPodLogs works for DCs only, so that needs fixing as well.

soltysh commented 1 week ago

Reverting changes to cluster-samples-operator in https://github.com/openshift/cluster-samples-operator/pull/542

adambkaplan commented 1 week ago

/close

Replacing with https://github.com/openshift/origin/pull/28732

openshift-ci[bot] commented 1 week ago

@adambkaplan: Closed this PR.

In response to [this](https://github.com/openshift/origin/pull/28718#issuecomment-2070638740): >/close > >Replacing with https://github.com/openshift/origin/pull/28732 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 week ago

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-32293. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/28718): >Failing Jenkins Pipeline test blocks multiple PRs from merging. As agreed, skipping these tests temporarily. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.