search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

SDN-4783: Add e2e tests for NetworkDiagnosticsConfig featuregate #28719

Open kyrtapz opened 2 weeks ago

kyrtapz commented 2 weeks ago

This is blocked by https://github.com/openshift/cluster-network-operator/pull/2339

openshift-ci-robot commented 2 weeks ago

@kyrtapz: This pull request references SDN-4783 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/28719): >This is blocked by https://github.com/openshift/cluster-network-operator/pull/2339 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ricky-rav commented 1 week ago

/lgtm Thanks, @kyrtapz!

trozet commented 1 week ago

/approve

openshift-ci[bot] commented 1 week ago

New changes are detected. LGTM label has been removed.

kyrtapz commented 1 week ago

/test images

kyrtapz commented 1 week ago

CI seems to be back /retest

kyrtapz commented 1 week ago

/test images

kyrtapz commented 1 week ago

/test images

kyrtapz commented 1 week ago

@dgoodwin are you ok with the cliet-go bump? It looks like the bot needs your blessing

kyrtapz commented 6 days ago

/retest

kyrtapz commented 6 days ago

/test ?

openshift-ci[bot] commented 6 days ago

@kyrtapz: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/origin/pull/28719#issuecomment-2076617534): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kyrtapz commented 6 days ago

/test e2e-gcp-ovn-techpreview /test e2e-gcp-ovn-techpreview-serial

dgoodwin commented 6 days ago

/approve

openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, kyrtapz, ricky-rav, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [dgoodwin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kyrtapz commented 6 days ago

/retest

kyrtapz commented 6 days ago

/test e2e-gcp-ovn-techpreview /test e2e-gcp-ovn-techpreview-serial

kyrtapz commented 5 days ago

/retest /test e2e-gcp-ovn-techpreview

kyrtapz commented 5 days ago

/test e2e-gcp-ovn-techpreview

openshift-trt-bot commented 5 days ago

Job Failure Risk Analysis for sha: fb53aaebc699e9e163132ef5a131adc7b39282da

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (23) are below the historical average (1013): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Medium
[sig-node][invariant] alert/TargetDown should not be at or above info in ns/kube-system
This test has passed 84.62% of 52 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node'] in the last 14 days.

Open Bugs
MCD degraded on content mismatch for resolv-prepender script
kyrtapz commented 2 days ago

/test e2e-gcp-ovn-techpreview

kyrtapz commented 2 days ago

Made the tests ordered so they do not run in parallel with each other:

~~Ordered is a decorator that allows you to mark a container as ordered. Specs in the container will always run in the order they appear. They will never be randomized and they will never run in parallel with one another, though they may run in parallel with other specs.~~

Apparently g.Ordered doesn't really work as expected here, the tests were still ran in parallel. I had to add [Serial] to ensure that multiple tests are not ran at the same time. @dgoodwin please lmk if it is acceptable to add the tests as serial.

kyrtapz commented 2 days ago

/test e2e-gcp-ovn-techpreview

kyrtapz commented 2 days ago

/test e2e-gcp-ovn-techpreview

openshift-trt-bot commented 2 days ago

Job Failure Risk Analysis for sha: a441dc9d69987b3bbbbd794a534ab2e387730460

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (13) are below the historical average (1097): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
kyrtapz commented 1 day ago

/test e2e-gcp-ovn-techpreview

kyrtapz commented 1 day ago

/test e2e-gcp-ovn-techpreview

kyrtapz commented 1 day ago

/retest /test e2e-gcp-ovn-techpreview

dgoodwin commented 1 day ago

~Made the tests ordered so they do not run in parallel with each other:~

~Ordered is a decorator that allows you to mark a container as ordered. Specs in the container will always run in the order they appear. They will never be randomized and they will never run in parallel with one another, though they may run in parallel with other specs.~

Apparently g.Ordered doesn't really work as expected here, the tests were still ran in parallel. I had to add [Serial] to ensure that multiple tests are not ran at the same time. @dgoodwin please lmk if it is acceptable to add the tests as serial.

I believe that moves them to the serial suite and thus they will then only run in serial jobs. I would not expect them to be running in e2e-gcp-ovn-techpreview anymore. How long does this set of tests take to run? Just want to ask in terms of time added to the suite.

kyrtapz commented 1 day ago

I believe that moves them to the serial suite and thus they will then only run in serial jobs. I would not expect them to be running in e2e-gcp-ovn-techpreview anymore. How long does this set of tests take to run? Just want to ask in terms of time added to the suite.

Each test has a timeout of 3mins, from my testing each test doesn't take more than a minute.

kyrtapz commented 1 day ago

/test e2e-gcp-ovn-techpreview-serial

kyrtapz commented 1 day ago

/test e2e-gcp-ovn-builds

dgoodwin commented 1 day ago

I believe that moves them to the serial suite and thus they will then only run in serial jobs. I would not expect them to be running in e2e-gcp-ovn-techpreview anymore. How long does this set of tests take to run? Just want to ask in terms of time added to the suite.

Each test has a timeout of 3mins, from my testing each test doesn't take more than a minute.

That should be fine in the serial suite.

openshift-ci[bot] commented 1 day ago

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview-serial 48369f75611a89b0b13d84965ea7ff311a7023be link false /test e2e-gcp-ovn-techpreview-serial
ci/prow/e2e-gcp-ovn-builds 48369f75611a89b0b13d84965ea7ff311a7023be link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-single-node-upgrade 48369f75611a89b0b13d84965ea7ff311a7023be link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).