search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

HOSTEDCP-1466: test/ginkgo: allow many external binaries #28720

Open stevekuznetsov opened 2 weeks ago

stevekuznetsov commented 2 weeks ago

Not only do we ultimately need to support external binaries from more than one image in the payload, we also need to support repositories that use go test for their end-to-end tests along with the old-school Ginkgo approach.

/assign @soltysh /cc @deads2k

openshift-ci-robot commented 2 weeks ago

@stevekuznetsov: This pull request references HOSTEDCP-1466 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/28720): >Not only do we ultimately need to support external binaries from more than one image in the payload, we also need to support repositories that use `go test` for their end-to-end tests along with the old-school Ginkgo approach. > >/assign @soltysh >/cc @deads2k Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stevekuznetsov Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial cb40f1902a2b6eb2fdd5e0ddc1fab35ae43da9c6 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn cb40f1902a2b6eb2fdd5e0ddc1fab35ae43da9c6 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade cb40f1902a2b6eb2fdd5e0ddc1fab35ae43da9c6 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).