search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.44k stars 4.69k forks source link

OCPBUGS-32293: Use In-Tree Template for Jenkins #28732

Closed adambkaplan closed 3 weeks ago

adambkaplan commented 3 weeks ago

Update the JenkinsPipeline build strategy test to use an in-tree template to deploy Jenkins during the test setup phase. This decouples the test from the Samples Operator, which is officially deprecated in 4.16 and will be phased out in the future. Previously, this test implicitly relied on the Samples Operator to install the Jenkins ephemeral template.

openshift-ci-robot commented 3 weeks ago

@adambkaplan: This pull request references Jira Issue OCPBUGS-32293, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/28732): >Update the JenkinsPipeline build strategy test to use an in-tree template to deploy Jenkins during the test setup phase. This decouples the test from the Samples Operator, which is officially deprecated in 4.16 and will be phased out in the future. Previously, this test implicitly relied on the Samples Operator to install the Jenkins ephemeral template. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
adambkaplan commented 3 weeks ago

/assign @soltysh

/cc @fbm3307 @sayan-biswas

This will decouple the JenkinsPipeline build test test from the Samples Operator. I'm setting aside the fact that we technically called this thing deprecated in OCP 4.3!

adambkaplan commented 3 weeks ago

/hold

This still has an implict dependency on the samples operator (Jenkins imagestream). Once I see the build test get back to "green," I'll fix that.

adambkaplan commented 3 weeks ago

/hold cancel

PR updated

adambkaplan commented 3 weeks ago

/retest

Build suite tests are passing! 😃

openshift-trt-bot commented 3 weeks ago

Job Failure Risk Analysis for sha: 2775d33feaa7ba78583c3a7ce942082297cfdcf2

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade IncompleteTests
Tests for this run (26) are below the historical average (717): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Low
[sig-arch] events should not repeat pathologically for ns/openshift-etcd-operator
This test has passed 53.70% of 54 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sayan-biswas commented 3 weeks ago

/retest

openshift-ci[bot] commented 3 weeks ago

@adambkaplan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial 2775d33feaa7ba78583c3a7ce942082297cfdcf2 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 2775d33feaa7ba78583c3a7ce942082297cfdcf2 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 weeks ago

@adambkaplan: Jira Issue OCPBUGS-32293: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32293 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin/pull/28732): >Update the JenkinsPipeline build strategy test to use an in-tree template to deploy Jenkins during the test setup phase. This decouples the test from the Samples Operator, which is officially deprecated in 4.16 and will be phased out in the future. Previously, this test implicitly relied on the Samples Operator to install the Jenkins ephemeral template. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.