openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.46k stars 4.7k forks source link

NO-JIRA: Drop Cluster Infra related exceptions from termination message policy tests #28798

Closed JoelSpeed closed 3 weeks ago

JoelSpeed commented 1 month ago

I believe these are all fixed now and we should no longer need to be excepted. Down with exceptions!

openshift-ci[bot] commented 1 month ago

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial 49460cc6f0d329a17630ea78dd80d01428101c7a link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node 49460cc6f0d329a17630ea78dd80d01428101c7a link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade 49460cc6f0d329a17630ea78dd80d01428101c7a link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dgoodwin commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [dgoodwin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 weeks ago

@JoelSpeed: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/28798): >I believe these are all fixed now and we should no longer need to be excepted. Down with exceptions! Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 3db56943a029b9adc8a81ca2af660a9687b2f292 and 2 for PR HEAD 49460cc6f0d329a17630ea78dd80d01428101c7a in total