search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

SDN-4930: network_segmentation: allow multiple UDN status conditions #29220

Closed npinaeva closed 4 weeks ago

npinaeva commented 1 month ago

Fix UDN status check to assert required condition is present in the status instead of checking that status has only 1 condition. required to make https://github.com/openshift/ovn-kubernetes/pull/2314 pass

trozet commented 1 month ago

/test e2e-gcp-ovn-techpreview

trozet commented 1 month ago

/test e2e-gcp-ovn-techpreview

trozet commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/networking/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/networking/OWNERS)~~ [trozet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
trozet commented 1 month ago

/retitle NOJIRA: network_segmentation: allow multiple UDN status conditions

trozet commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@trozet: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/origin/pull/29220#issuecomment-2430126706): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
trozet commented 1 month ago

/label jira/valid-reference

openshift-ci[bot] commented 1 month ago

@trozet: The label(s) /label jira/valid-reference cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to [this](https://github.com/openshift/origin/pull/29220#issuecomment-2430138493): >/label jira/valid-reference Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
trozet commented 1 month ago

/label jira/valid-bug

openshift-ci[bot] commented 1 month ago

@trozet: Can not set label jira/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to [this](https://github.com/openshift/origin/pull/29220#issuecomment-2430139262): >/label jira/valid-bug Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
trozet commented 1 month ago

/retitle NO-JIRA: network_segmentation: allow multiple UDN status conditions

openshift-ci-robot commented 1 month ago

@npinaeva: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/29220): >Fix UDN status check to assert required condition is present in the status instead of checking that status has only 1 condition. >required to make https://github.com/openshift/ovn-kubernetes/pull/2314 pass Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
trozet commented 1 month ago

/skip

trozet commented 1 month ago

/retest-required

trozet commented 1 month ago

/override ci/prow/e2e-gcp-ovn /override ci/prow/e2e-gcp-ovn-upgrade

openshift-ci[bot] commented 1 month ago

@trozet: trozet unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/origin/pull/29220#issuecomment-2430148231): >/override ci/prow/e2e-gcp-ovn >/override ci/prow/e2e-gcp-ovn-upgrade Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 9a6a83bf56952bd58929aa5d68b0986a2ccf4b8c and 2 for PR HEAD 7aa6b178093b58347b75fbf52614054c7deda06e in total

openshift-ci[bot] commented 1 month ago

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi 7aa6b178093b58347b75fbf52614054c7deda06e link false /test e2e-gcp-csi
ci/prow/e2e-agnostic-ovn-cmd 7aa6b178093b58347b75fbf52614054c7deda06e link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-ovn 7aa6b178093b58347b75fbf52614054c7deda06e link false /test e2e-metal-ipi-ovn
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 7aa6b178093b58347b75fbf52614054c7deda06e link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-cgroupsv2 7aa6b178093b58347b75fbf52614054c7deda06e link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 7aa6b178093b58347b75fbf52614054c7deda06e link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-upgrade 7aa6b178093b58347b75fbf52614054c7deda06e link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn 7aa6b178093b58347b75fbf52614054c7deda06e link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tssurya commented 1 month ago

/tide refresh

tssurya commented 1 month ago

/retitle SDN-4930: network_segmentation: allow multiple UDN status conditions

openshift-ci-robot commented 1 month ago

@npinaeva: This pull request references SDN-4930 which is a valid jira issue.

In response to [this](https://github.com/openshift/origin/pull/29220): >Fix UDN status check to assert required condition is present in the status instead of checking that status has only 1 condition. >required to make https://github.com/openshift/ovn-kubernetes/pull/2314 pass Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tssurya commented 1 month ago

/shrug

tssurya commented 1 month ago

/tide refresh

openshift-bot commented 4 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202410231641.p0.g0c09074.assembly.stream.el9. All builds following this will include this PR.

tssurya commented 3 weeks ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 3 weeks ago

@tssurya: new pull request created: #29259

In response to [this](https://github.com/openshift/origin/pull/29220#issuecomment-2451538039): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.