search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

NO-JIRA: tls registry: don't store annotation values in violations #29227

Closed vrutkovs closed 3 weeks ago

vrutkovs commented 4 weeks ago

Violations JSON should only contain artifact locations and should not be updated when their annotation changes

openshift-ci-robot commented 4 weeks ago

@vrutkovs: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/29227): >Violations JSON should only contain artifact locations and should not >be updated when their annotation changes Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dinhxuanvu commented 4 weeks ago

/hold

vrutkovs commented 4 weeks ago

/hold cancel

Removed updates to vendor/

deads2k commented 4 weeks ago

/approve

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dinhxuanvu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [deads2k] - ~~[tls/violations/OWNERS](https://github.com/openshift/origin/blob/master/tls/violations/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 4560b2be97bfb63bab49409640bf99fd2d04e769 and 2 for PR HEAD f1ee59d29f5487c5036326ee3d8e4fefc5f96ed6 in total

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 4560b2be97bfb63bab49409640bf99fd2d04e769 and 2 for PR HEAD f1ee59d29f5487c5036326ee3d8e4fefc5f96ed6 in total

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 4560b2be97bfb63bab49409640bf99fd2d04e769 and 2 for PR HEAD f1ee59d29f5487c5036326ee3d8e4fefc5f96ed6 in total

dinhxuanvu commented 3 weeks ago

/retest-required

openshift-ci[bot] commented 3 weeks ago

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade f1ee59d29f5487c5036326ee3d8e4fefc5f96ed6 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial f1ee59d29f5487c5036326ee3d8e4fefc5f96ed6 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-ovn f1ee59d29f5487c5036326ee3d8e4fefc5f96ed6 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-agnostic-ovn-cmd f1ee59d29f5487c5036326ee3d8e4fefc5f96ed6 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout f1ee59d29f5487c5036326ee3d8e4fefc5f96ed6 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202410261039.p0.g6f6a284.assembly.stream.el9. All builds following this will include this PR.